Bluetooth: Mesh: use secure storage in ble mesh #82319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: mbedTLS / PSA Crypto
area: Bluetooth Mesh
area: Secure Storage
zephyrbot
requested review from
Andrewpini,
HaavardRei,
KyraLengfeld,
LingaoM,
PavelVPV,
akredalen,
ceolin,
d3zd3z,
ithinuel,
jhedberg,
omkar3141,
tomi-font and
valeriosetti
tomi-font
requested changes
Nov 29, 2024
Contributor
tomi-font
left a comment
tomi-font
left a comment
There was a problem hiding this comment.
Might also be worth a migration guide entry to indicate that it's now necessary to select the affected Kconfig options for the secure storage subsystem.
alxelax
force-pushed
the
remove_psa_its_emulator
branch
from
63bf345 to
8321d0b
Compare
alxelax
force-pushed
the
remove_psa_its_emulator
branch
from
8321d0b to
1bb8e85
Compare
alxelax
force-pushed
the
remove_psa_its_emulator
branch
from
1bb8e85 to
a1685a0
Compare
Balaklaka
reviewed
Dec 3, 2024
tomi-font
reviewed
Dec 3, 2024
alxelax
force-pushed
the
remove_psa_its_emulator
branch
from
a1685a0 to
e3ee4e9
Compare
Balaklaka
approved these changes
Dec 4, 2024
alxelax
dismissed
tomi-font’s stale review
Just gave up to adapt secure storage tests and made changes only in mesh related code with depends on SECURE_STORAGE
alxelax
removed
Release Notes
Contributor
|
The commit title says "use psa crypto storage in mesh bsim", but you change files in modules/, samples/, subsys/.../Kconfig and tests/. Maybe this can be split into three? (Modules, samples/Kconfig and bsim, or something like this) |
Contributor
Author
Almost all changes are related. It is not possible to remove I will add more description details in commit message for better understanding. |
Commit: - adds dependency of the mbedtls psa usage on secure storage - removes PSA ITS emulator and enables usage of the secure storage in ble mesh bsim tests - enables secure storage in all ble mesh and related samples Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax
force-pushed
the
remove_psa_its_emulator
branch
from
88ff6d3 to
29a3bf5
Compare
alxelax
changed the title
HaavardRei
approved these changes
Jan 10, 2025
KyraLengfeld
approved these changes
Jan 13, 2025
PavelVPV
requested changes
Jan 14, 2025
tomi-font
approved these changes
Jan 14, 2025
Contributor
tomi-font
left a comment
tomi-font
left a comment
There was a problem hiding this comment.
Looks good! I just found this point not very clear in your commit message:
- adds dependency of the mbedtls psa usage on secure storage
I think I get what you mean after having reviewed the changes, but it could be made clearer IMO. Also, maybe worth having something in the migration guide or release notes?
PavelVPV
approved these changes
Jan 14, 2025
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 17, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 17, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 17, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 17, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 17, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 17, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 17, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 21, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 21, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 22, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
JordanYates
added a commit
to Embeint/zephyr
that referenced
this pull request
Feb 22, 2025
Re-add the option to use the MbedTLS ITS backend on posix. This backend is much simpler to setup than the Zephyr backends in a testing environment. This was previously removed in: zephyrproject-rtos#82319 Signed-off-by: Jordan Yates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR:
the secure storage in ble mesh bsim tests