drivers: regulator: add support for AXP2101 power management IC #82474

lfelten · 2024-12-03T10:19:20Z

Add initial support for the AXP2101 power management IC from X-powers

gmarull · 2024-12-05T08:18:05Z

dts/bindings/regulator/x-powers,axp2101-regulator.yaml

you are missing a top-level compatible here, this is a MFD device. It's ok to just add support for regulators now, but DT layout needs to be designed according to how device is.

tests/drivers/build_all/regulator/i2c.dtsi

gmarull · 2024-12-05T08:18:59Z

drivers/regulator/regulator_axp2101.c

Suggested change

if (ret != 0) {

if (ret < 0) {

others as well

Hi @gmarull
thanks, I changed the if statements

gmarull · 2024-12-05T08:19:54Z

drivers/regulator/regulator_axp2101.c

Is instance level logging really needed? Very few drivers do this, and, in most cases, I'd say there's only a single regulator instance on a system.

Hi @gmarull,
I remove the per instance logging.

kartben · 2024-12-12T21:50:54Z

This is a duplicate of #78098? You may want to avoid duplicating effort @lfelten

lfelten · 2024-12-12T22:05:44Z

This is a duplicate of #78098?

Indeed, sorry, didn't check before submitting this one.

lfelten · 2024-12-16T09:59:41Z

@kartben @gmarull @soburi @ranranff
I compared the drivers, they have similar functionality except that ranranff added the work mode setting.
Should I add the workmode setting here or fix ranranffs driver?

soburi · 2024-12-16T10:26:24Z

@lfelten

Your and Ranranff's codes are obviously similar because they are copied from regulator_axp192.c. Since the implementation is almost the same, and only the definition is different, I think it is preferable to support it as an extension of regulator_axp192.c.

I tried making something based on your code.

soburi@6c74c9d
(And one previous commit.)

I have yet to test it, but I hope it helps.

lfelten · 2024-12-16T10:45:00Z

@soburi
Thanks!
I have a patch that adds the sets the workmode for this driver (#82474).
I can test it on one board, but that only uses some DC/DC and LDOs.

@lfelten

Your and Ranranff's codes are obviously similar because they are copied from regulator_axp192.c. Since the implementation is almost the same, and only the definition is different, I think it is preferable to support it as an extension of regulator_axp192.c.

I tried making something based on your code.

soburi@6c74c9d (And one previous commit.)

I have yet to test it, but I hope it helps.

drivers/regulator/regulator_axp2101.c

lfelten · 2024-12-17T19:52:21Z

@soburi
The logging was still per instance. @gmarull asked to remove this as usually there is only one PMIC on a board/design.
The tests on my board were successful.

soburi

LGTM.

It would help if you still addressed pointed by @gmarull #82474 (comment).

lfelten · 2024-12-19T11:03:38Z

LGTM.

It would help if you still addressed pointed by @gmarull #82474 (comment).

Thanks!
Sorry, that got lost while merging. I added a new version (this is the only change).

dts/bindings/regulator/x-powers,axp2101-regulator.yaml

lfelten · 2025-01-23T09:24:02Z

@soburi I still have no hardware that uses a DC/DC besides DCDC1, sorry.
Here is a summary of the changes:

converted all ranges to unsigned decimal notation
corrected ranges for dcdc2, dcdc3, dcdc4
corrected vsel masks for dcdc2, dcdc3, dcdc4, dcdc5
consolidated ranges for ald1/2/3/4 and bldo1/2 into abldox (range is the same)
rebased to main

soburi · 2025-01-26T05:03:05Z

@lfelten

I still have no hardware that uses a DC/DC besides DCDC1, sorry.

Please note this in the commit message about this.

soburi

LGTM

soburi · 2025-01-27T21:29:18Z

@gmarull
Could you take a look again?

lfelten · 2025-01-31T10:09:40Z

@soburi I added the remark to the git commit log as you requested and rebased it to main.
@gmarull can you please review?

include/zephyr/drivers/mfd/axp2101.h

gmarull · 2025-02-17T08:52:14Z

drivers/mfd/mfd_axp192.c


-DT_INST_FOREACH_STATUS_OKAY(MFD_AXP192_DEFINE);
+DT_FOREACH_STATUS_OKAY_VARGS(x_powers_axp192, MFD_AXP192_DEFINE, 192);
+DT_FOREACH_STATUS_OKAY_VARGS(x_powers_axp2101, MFD_AXP192_DEFINE, 2101);


rename definition macro to make it clear that covers 2 pmic

I hope I understood it right: I renamed MFD_AXP192_DEFINE to MFD_AXP192__AXP2101_DEFINE to indicate it applies to axp192 and axp2101.

gmarull · 2025-02-17T08:52:40Z

drivers/regulator/regulator_axp192.c

 #include <zephyr/logging/log_instance.h>
 #include <zephyr/drivers/mfd/axp192.h>

-LOG_MODULE_REGISTER(regulator_axp192, CONFIG_REGULATOR_LOG_LEVEL);


why moving this?

Hi, moved it back, sorry.

Add initial support for the AXP2101 power management IC from X-powers. Remark: only DC/DC1 and ALDO have been tested on real hardware. Co-authored-by: TOKITA Hiroshi <[email protected]> Co-authored-by: Gerard Marull-Paretas <[email protected]> Signed-off-by: Lothar Felten <[email protected]>

lfelten · 2025-02-18T08:44:32Z

Rebased to current main branch
@gmarull: your requested changes were added.
I also fixed the register defines (#ifdef... clause) for AXP2101

zephyrbot added the area: Regulators label Dec 3, 2024

zephyrbot requested review from aasinclair, danieldegrasse and gmarull December 3, 2024 10:19

zephyrbot assigned gmarull Dec 3, 2024

lfelten force-pushed the xpowers_axp2101 branch from 6426c15 to 16d230b Compare December 3, 2024 10:34

gmarull reviewed Dec 5, 2024

View reviewed changes

lfelten marked this pull request as draft December 10, 2024 09:15

lfelten force-pushed the xpowers_axp2101 branch 2 times, most recently from f02b2fc to 24296fd Compare December 12, 2024 21:32

lfelten force-pushed the xpowers_axp2101 branch from 24296fd to 479ff76 Compare December 12, 2024 22:04

lfelten marked this pull request as ready for review December 13, 2024 13:03

zephyrbot added the area: MFD label Dec 13, 2024

soburi requested changes Dec 16, 2024

View reviewed changes

drivers/regulator/regulator_axp2101.c Outdated Show resolved Hide resolved

lfelten force-pushed the xpowers_axp2101 branch from 479ff76 to 8090c68 Compare December 17, 2024 19:50

lfelten requested review from gmarull and soburi December 18, 2024 07:18

soburi previously approved these changes Dec 19, 2024

View reviewed changes

lfelten dismissed soburi’s stale review via 78b2ccf December 19, 2024 11:02

lfelten force-pushed the xpowers_axp2101 branch from 8090c68 to 78b2ccf Compare December 19, 2024 11:02

soburi reviewed Dec 19, 2024

View reviewed changes

dts/bindings/regulator/x-powers,axp2101-regulator.yaml Outdated Show resolved Hide resolved

lfelten force-pushed the xpowers_axp2101 branch from 78b2ccf to c90deed Compare December 19, 2024 12:42

soburi previously approved these changes Dec 19, 2024

View reviewed changes

lfelten force-pushed the xpowers_axp2101 branch 2 times, most recently from 30eba8f to c7553b6 Compare January 23, 2025 09:21

lfelten force-pushed the xpowers_axp2101 branch from c7553b6 to c19a915 Compare January 23, 2025 11:57

soburi previously approved these changes Jan 26, 2025

View reviewed changes

lfelten force-pushed the xpowers_axp2101 branch from c19a915 to 9ea5d0d Compare January 31, 2025 10:08

gmarull reviewed Feb 3, 2025

View reviewed changes

include/zephyr/drivers/mfd/axp2101.h Outdated Show resolved Hide resolved

lfelten dismissed soburi’s stale review via 09e874d February 3, 2025 14:40

lfelten force-pushed the xpowers_axp2101 branch 4 times, most recently from a5e6394 to fcf787c Compare February 3, 2025 22:13

lfelten requested review from gmarull and soburi February 4, 2025 06:27

gmarull reviewed Feb 17, 2025

View reviewed changes

lfelten force-pushed the xpowers_axp2101 branch 2 times, most recently from 7bf4fd4 to f211b83 Compare February 17, 2025 21:25

lfelten force-pushed the xpowers_axp2101 branch from f211b83 to d162cda Compare February 17, 2025 21:33

lfelten requested a review from gmarull February 18, 2025 08:45

gmarull approved these changes Feb 20, 2025

View reviewed changes

gmarull requested a review from fabiobaltieri February 27, 2025 10:19

fabiobaltieri approved these changes Feb 27, 2025

View reviewed changes

fabiobaltieri added this to the v4.2.0 milestone Feb 27, 2025

soburi approved these changes Feb 27, 2025

View reviewed changes

carlescufi merged commit 1c50c3a into zephyrproject-rtos:main Mar 7, 2025
23 checks passed

drivers: regulator: add support for AXP2101 power management IC #82474

drivers: regulator: add support for AXP2101 power management IC #82474

Uh oh!

Conversation

lfelten commented Dec 3, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartben commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lfelten commented Dec 12, 2024

Uh oh!

lfelten commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soburi commented Dec 16, 2024

Uh oh!

lfelten commented Dec 16, 2024

Uh oh!

Uh oh!

lfelten commented Dec 17, 2024

Uh oh!

soburi left a comment

Choose a reason for hiding this comment

Uh oh!

lfelten commented Dec 19, 2024

Uh oh!

Uh oh!

lfelten commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soburi commented Jan 26, 2025

Uh oh!

soburi left a comment

Choose a reason for hiding this comment

Uh oh!

soburi commented Jan 27, 2025

Uh oh!

lfelten commented Jan 31, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lfelten commented Feb 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kartben commented Dec 12, 2024 •

edited

Loading

lfelten commented Dec 16, 2024 •

edited

Loading

lfelten commented Jan 23, 2025 •

edited

Loading