tests: drivers: pwm: Revert PWM capture change for pulse check #82623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts a change regarding how the test checks the pulse output from a capture event. A pulse capture will produce a value that has the same polarity (and range) as programmed by pwm_capture(). Checking 'pulse_capture' against 'period - pulse' means expecting the driver to return a capture value that is not inverted as well, which would cause test cases to fail. Signed-off-by: Raffael Rostagno <[email protected]>
henrikbrixandersen
approved these changes
Dec 5, 2024
sylvioalves
approved these changes
Dec 12, 2024
Contributor
|
@ioannis-karachalios , as the owner of the reverted commit, can you take a look? |
bjarki-andreasen
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a change from #81198 regarding how the test checks the pulse output from a capture event. A pulse capture will produce a value that has the same polarity (and range) as programmed by pwm_capture(). Checking 'pulse_capture' against 'period - pulse' means expecting the driver to return a capture value that is not inverted as well, which would cause test cases to fail.