Skip to content

Bluetooth: ATT: Disconnect ATT and ACL when receiving inval rsp #83222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabiobaltieri merged 1 commit into from
Feb 10, 2025
Merged

Bluetooth: ATT: Disconnect ATT and ACL when receiving inval rsp #83222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions subsys/bluetooth/host/att.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* SPDX-License-Identifier: Apache-2.0
*/

#include <zephyr/bluetooth/addr.h>
#include <zephyr/bluetooth/conn.h>
#include <zephyr/kernel.h>
#include <string.h>
#include <errno.h>
Expand Down Expand Up @@ -295,6 +297,28 @@ struct net_buf *bt_att_create_rsp_pdu(struct bt_att_chan *chan, uint8_t op);

static void bt_att_sent(struct bt_l2cap_chan *ch);

static void att_disconnect(struct bt_att_chan *chan)
{
char addr[BT_ADDR_LE_STR_LEN];
int err;

/* In rare circumstances we are "forced" to disconnect the ATT bearer and the ACL.
* Examples of when this is right course of action is when there is an ATT timeout, we
* receive an unexpected response from the server, or the response from the server is
* invalid
*/

bt_addr_le_to_str(bt_conn_get_dst(chan->att->conn), addr, sizeof(addr));
LOG_DBG("ATT disconnecting device %s", addr);

bt_att_disconnected(&chan->chan.chan);

err = bt_conn_disconnect(chan->chan.chan.conn, BT_HCI_ERR_REMOTE_USER_TERM_CONN);
if (err) {
LOG_ERR("Disconnecting failed (err %d)", err);
}
}

static void att_sent(void *user_data)
{
struct bt_att_tx_meta_data *data = user_data;
Expand Down Expand Up @@ -930,7 +954,8 @@ static uint8_t att_handle_rsp(struct bt_att_chan *chan, void *pdu, uint16_t len,

if (!chan->req) {
LOG_WRN("No pending ATT request");
goto process;
att_disconnect(chan);
return 0; /* Returning a non-0 value would attempt to send an error response */
}

/* Check if request has been cancelled */
Expand Down Expand Up @@ -3139,9 +3164,7 @@ static void att_timeout(struct k_work *work)
{
char addr[BT_ADDR_LE_STR_LEN];
struct k_work_delayable *dwork = k_work_delayable_from_work(work);
struct bt_att_chan *chan = CONTAINER_OF(dwork, struct bt_att_chan,
timeout_work);
int err;
struct bt_att_chan *chan = CONTAINER_OF(dwork, struct bt_att_chan, timeout_work);

bt_addr_le_to_str(bt_conn_get_dst(chan->att->conn), addr, sizeof(addr));
LOG_ERR("ATT Timeout for device %s. Disconnecting...", addr);
Expand All @@ -3154,17 +3177,13 @@ static void att_timeout(struct k_work *work)
* requests, commands, indications or notifications shall be sent to the
* target device on this ATT Bearer.
*/
bt_att_disconnected(&chan->chan.chan);

/* The timeout state is local and can block new ATT operations, but does not affect the
* remote side. Disconnecting the GATT connection upon ATT timeout simplifies error handling
* for developers. This reduces rare failure conditions to a common one, allowing developers
* to handle unexpected disconnections without needing special cases for ATT timeouts.
*/
err = bt_conn_disconnect(chan->chan.chan.conn, BT_HCI_ERR_REMOTE_USER_TERM_CONN);
if (err) {
LOG_ERR("Disconnecting failed (err %d)", err);
}
att_disconnect(chan);
}

static struct bt_att_chan *att_get_fixed_chan(struct bt_conn *conn)
Expand Down
Loading