Skip to content

Conversation

@dottspina
Copy link
Contributor

@dottspina dottspina commented Mar 14, 2025

Relicense to Apache-2.0 the YAML test files introduced by commit ee5c520.

I didn't touch the test files I' not the author of. @mbolivar may know why the BSD-3-clause was chosen for these the other files at this time, and whether relicensing them is possible.

References:

Relicense to Apache-2.0 the YAML test files
introduced by commit ee5c520.

Signed-off-by: Christophe Dufaza <[email protected]>
@JarmouniA JarmouniA added the Licensing The PR has licensing issues => licensing expert to review label Mar 14, 2025
@fabiobaltieri
Copy link
Member

Cool, can you also drop the note that I added in #86577 while at it?

@dottspina
Copy link
Contributor Author

Cool, can you also drop the note that I added in #86577 while at it?

I only re-licensed the files I authored, there are still quite a few YAML files (and some DTS) under the BSD-3-clause license in the scripts/dts/python-devicetree/tests directory the note is about.

Should I also fix the files that are still under BSD-3-clause (may be in a different commit to make it clear)?
Or simply drop the note anyway?

@fabiobaltieri
Copy link
Member

Oh I see that now, yeah let's just do this then, thanks for clarifying.

Copy link
Contributor

@mbolivar mbolivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this PR?

The python-devicetree package source files are BSD 3 clause and have been since the beginning when @ulfalizer first wrote them. I don't think mixing licenses like this makes sense -- test cases should ideally be licensed identically to the code being tested, to avoid potential contamination if you migrate code between implementation and test -- and the PR is not providing a justification.

@fabiobaltieri
Copy link
Member

Why this PR?

I asked for it because I noticed a bunch of files introduced under a non Apache license in this cycle, one of the step of the release is to make sure the license page is up to date. Did not realize that there were existing files with that license though, mainly because there was not an entry in the license file, which there is now so I guess this is not strictly needed anymore since it's not changing all the files and we have to keep that entry anyway.

@decsny
Copy link
Member

decsny commented Mar 28, 2025

I think I am agreeing with marti here, the python devicetree scripts are pretty much all BSD-3 license so do not think this is a big deal. And maybe he is right that it is better to keep consistent with test yamls, IDK though, I lack experience there. To me it seems silly to have licenses and copyrights on configuration files in the first place but what do I know

@mbolivar
Copy link
Contributor

Thanks for the explanation @fabiobaltieri -- should we close this, then?

@fabiobaltieri
Copy link
Member

Thanks for the explanation @fabiobaltieri -- should we close this, then?

Yeah fine by me, apologies for the extra work @dottspina, at least this now has a reference should not create any more ambiguity.

@dottspina dottspina deleted the pr-relicense-yaml-files-79900 branch March 31, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree Licensing The PR has licensing issues => licensing expert to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants