toolchain: llvm: Use clang's __INTN_C/__UINTN_C macros for clang 20+ #87717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang recently began providing predefined __INTN_C/__UINTN_C macros resulting in macro redefinition warnings in toolchain/llvm.h. This change was landed in clang in late Jan. 2025 and clang/LLVM 20 is the first official release that has this support (see the PR linked below). Prefer the definitions provided by clang and avoid redefining these macros for clang versions 20 and later to avoid said warnings. Link: llvm/llvm-project#123514 Signed-off-by: Jonathon Penix <[email protected]>
Contributor
Author
|
I can't add reviewers, but @duda-patryk please also take a look if possible! |
bjorniuppsala
approved these changes
Mar 27, 2025
tejlmand
approved these changes
Mar 27, 2025
duda-patryk
approved these changes
Mar 31, 2025
Contributor
|
The first release that included these was actually 20.1. There was no 20.0, but if you built llvm from source, it could exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang recently began providing predefined __INTN_C/__UINTN_C macros resulting in macro redefinition warnings in toolchain/llvm.h. This change was landed in clang in late Jan. 2025 and clang/LLVM 20 is the first official release that has this support (see the PR linked below).
Prefer the definitions provided by clang and avoid redefining these macros for clang versions 20 and later to avoid said warnings.
Link: llvm/llvm-project#123514