Microchip MEC5 HAL based SPI driver for QSPI controller #89122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: SPI
github-actions
bot
requested review from
VenkatKotakonda,
jvasanth1,
tbursztyka and
teburd
nordicjm
previously requested changes
Apr 28, 2025
scottwcpg
force-pushed
the
pr_spi_driver_mec5_qspi
branch
from
b83b69c to
3ac7f28
Compare
tbursztyka
requested changes
Apr 28, 2025
Contributor
tbursztyka
left a comment
tbursztyka
left a comment
There was a problem hiding this comment.
spi api does not support dual/quad/octal. Yes there are config options for it, but since it does not provide any means to actually configure everything else around ... I made a proposal to get a proper support long ago (see #39991 ) but it never caught any traction. It was assumed to be unnecessary. No one came since to request it, and instead we got a completely different api (mspi) competing with spi api...
so drop the dual/quad/octal for now, focus on the generic, and see my comments on the overall logic.
scottwcpg
force-pushed
the
pr_spi_driver_mec5_qspi
branch
from
3ac7f28 to
fb501d3
Compare
Contributor
Author
|
@tbursztyka Hi. Made the changes you requested and pushed an update. |
pdgendt
previously requested changes
May 8, 2025
scottwcpg
force-pushed
the
pr_spi_driver_mec5_qspi
branch
from
fb501d3 to
e2e2f60
Compare
Contributor
Author
|
Ran twister local for all four boards. No errors. |
pdgendt
reviewed
May 10, 2025
scottwcpg
force-pushed
the
pr_spi_driver_mec5_qspi
branch
2 times, most recently
from
ca84b9f to
bfa56b6
Compare
pdgendt
reviewed
May 12, 2025
Contributor
pdgendt
left a comment
pdgendt
left a comment
There was a problem hiding this comment.
Some more implicit booleans.
scottwcpg
force-pushed
the
pr_spi_driver_mec5_qspi
branch
from
bfa56b6 to
091416b
Compare
|
tbursztyka
reviewed
May 14, 2025
Contributor
tbursztyka
left a comment
tbursztyka
left a comment
There was a problem hiding this comment.
just a tiny comment, rest lgtm
SPI driver for Microchip MEC5 HAL based QSPI controller. QSPI hardware supports full duplex, dual, and quad operation. MEC5 QSPI controller also includes three local DMA channels per direction to off load firmware. The driver API supports full or half-duplex. Due to QSPI hardware not supporting one wire half-duplex, this driver supports full-duplex only. QSPI hardware design requires it to control chip select and current hardware supports up to two chip selects. Zephyr's SPI DT macros store the child SPI device's reg properity as the "slave" member of the SPI configuration structure. The driver uses the "slave" value as the chip select. Additional timing settings specific to SPI flash devices are in a new SPI device YAM file: "microchip,mec5-qspi-device.yaml" which includes the standard "spi-device.yaml". If the new YAML is not used, the QSPI controller will use default timing values for chip select and I/O line taps. Signed-off-by: Scott Worley <[email protected]>
Add Microchip MEC5 HAL based mec_assy6941 evaluation board to the Zephyr SPI loopback driver test. Signed-off-by: Scott Worley <[email protected]>
scottwcpg
force-pushed
the
pr_spi_driver_mec5_qspi
branch
from
091416b to
f003ea4
Compare
tbursztyka
approved these changes
May 14, 2025
albertofloyd
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microchip MEC5 HAL based SPI driver using QSPI controller. Driver supports async and extended SPI. Driver is compatible with flash SPI_NOR driver. PR includes a commit adding the board to the SPI loopback test.