stm32mp13: addition of i2c and ltdc support for the stm32mp135f-dk #89229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
HoZHel,
asm5878,
benothmn-st,
djiatsaf-st,
erwango,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
nordic-krch
erwango
requested review from
arnopo
and removed request for
asm5878 and
benothmn-st
avolmat-st
force-pushed
the
stm32mp13_i2c_ltdc_addition
branch
from
292b5cc to
24d40d5
Compare
github-actions
bot
requested review from
VynDragon,
asm5878,
benothmn-st,
danieldegrasse and
jfischer-no
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_stm32
DNM (manifest)
Author
|
a first west.yml update is done in order to be able to perform compile test. Such commit will have to be ignored in the final pull request. |
erwango
previously approved these changes
Apr 30, 2025
added 5 commits
April 30, 2025 14:38
Update hal_stm32 revision to include the MP13 HAL update. Signed-off-by: Alain Volmat <[email protected]>
Addition of the DCMIPP and DDR modules. Signed-off-by: Alain Volmat <[email protected]>
Add code to handle stm32_clock_control_get_subsys_rate for all i2c instances from I2C1 to I2C5. Signed-off-by: Alain Volmat <[email protected]>
Replace the usage of __HAL_LTDC_RELOAD_CONFIG which is a legacy API with __HAL_LTDC_RELOAD_IMMEDIATE_CONFIG Signed-off-by: Alain Volmat <[email protected]>
Add description of all 5 instances (i2c1 to i2c5) available on the stm32mp13 soc. Signed-off-by: Alain Volmat <[email protected]>
avolmat-st
force-pushed
the
stm32mp13_i2c_ltdc_addition
branch
from
24d40d5 to
8d45b87
Compare
Author
|
Updated west.yml hal_stm32 revision now that hal_stm32 update is merged. |
erwango
previously approved these changes
Apr 30, 2025
github-actions
bot
removed
the
DNM (manifest)
arnopo
requested changes
Apr 30, 2025
Contributor
arnopo
left a comment
arnopo
left a comment
There was a problem hiding this comment.
few comments, after that look good to me
added 5 commits
April 30, 2025 16:41
The non-secure LTDC plane has its own register for clock gating hence add an entry to control this. Signed-off-by: Alain Volmat <[email protected]>
Add the node describing the LTDC available in the stm32mp135. Signed-off-by: Alain Volmat <[email protected]>
…board The stm32mp135f_dk board has 3 i2c instances enabled and feature a 480x272 panel controlled via the LTDC. Signed-off-by: Alain Volmat <[email protected]>
blue and red leds polarity is ACTIVE_LOW hence correct the DT to have them behave correctly. Signed-off-by: Alain Volmat <[email protected]>
The stm32mp135f_dk board embeds an I/O expander to get access to more I/O. Led 3 (green) and Led 4 (orange) are accessible via this I/O expander. Signed-off-by: Alain Volmat <[email protected]>
avolmat-st
force-pushed
the
stm32mp13_i2c_ltdc_addition
branch
from
8d45b87 to
82b420d
Compare
arnopo
approved these changes
Apr 30, 2025
erwango
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on the hal_stm32 PR
Update the STM32MP13XX to v1.2.0 tag + various fixes #277 in order to enable i2c and ltdc on the stm32mp13.
It first add new entries necessary to enable some new drivers from the HAL such as DCMIPP.
stm32 clock control updates for the i2c in order to be able to get enough information regarding clocking to properly configure the i2c IP of the MP13.
DT updates for stm32mp13 (i2c) and stm32mp135 (ltdc) in order to describe i2c and ltdc instances
Update of the stm32mp135f-dk dts file to enable instances available on that board.
The I/O expander available on the board (and controlled via i2c) is then added in order to gain access to further peripheral later on (for the time being only led 3 and led 4)