Skip to content

Conversation

natto1784
Copy link
Contributor

@natto1784 natto1784 commented Jun 16, 2025

Make sure the capabilities bitfield fits the standard SD Association
specification and move the extra capabilities to props.

Affected Drivers:

  • ifx_cat1_sdio
  • imx_usdhc
  • intel_emmc_host
  • rcar_mmc
  • sdhc_ambiq
  • sdhc_esp32
  • sdhc_max32
  • sdhc_renesas_ra
  • sdhc_stm32
  • xlnx_sdhc

Affected Subsys

  • sd

Reference: 2.2.26, SD Specifications, Part A2, SD Host Controller
Simplified Specification, Version 4.20
URL: https://www.sdcard.org/downloads/pls/pdf/?p=PartA2_SD%20Host_Controller_Simplified_Specification_Ver4.20.jpg

@natto1784 natto1784 changed the title Sdhci caps drivers: sdhc: split caps into standard and extra Jun 16, 2025
@natto1784 natto1784 force-pushed the sdhci_caps branch 2 times, most recently from 37c0bf6 to 461664a Compare June 25, 2025 13:17
@natto1784 natto1784 marked this pull request as ready for review June 25, 2025 13:17
@github-actions github-actions bot added platform: Ambiq Ambiq platform: Infineon Infineon Technologies AG platform: Renesas R-Car Renesas R-Car platform: ESP32 Espressif ESP32 platform: Xilinx AMD Xilinx platform: ADI Analog Devices, Inc. platform: NXP Drivers NXP Semiconductors, drivers platform: Renesas RA Renesas Electronics Corporation, RA area: Disk Access labels Jun 25, 2025
@natto1784 natto1784 requested a review from danieldegrasse June 25, 2025 13:19
sylvioalves
sylvioalves previously approved these changes Sep 18, 2025
@maass-hamburg
Copy link
Member

@natto1784 needs a rebase

@natto1784
Copy link
Contributor Author

rebased

@maass-hamburg
Copy link
Member

you need to apply this change to #96878 too, which got merged in between (prop #96937 too)

@natto1784
Copy link
Contributor Author

you need to apply this change to #96878 too, which got merged in between (prop #96937 too)

@maass-hamburg good catch, updated, thanks!

@natto1784 natto1784 force-pushed the sdhci_caps branch 2 times, most recently from 0bacc66 to 7a75c56 Compare October 8, 2025 09:22
Comment on lines 101 to 102
* Moved extra fields from :c:struct:`sdhc_host_caps` to :c:struct:`sdhc_host_props` as per the
`SD Host Controller Specification <https://www.sdcard.org/downloads/pls/pdf/?p=PartA2_SD%20Host_Controller_Simplified_Specification_Ver4.20.jpg>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add reference to this pr and name the moved props.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done thanks!

Make sure the capability bitfields fit the standard SD Association
specification and move the extra capabilities to props.

Affected Drivers:
- ifx_cat1_sdio
- imx_usdhc
- intel_emmc_host
- rcar_mmc
- sdhc_ambiq
- sdhc_esp32
- sdhc_max32
- sdhc_renesas_ra
- sdhc_stm32
- xlnx_sdhc

Affected Subsys
- sd

Reference: 2.2.26, SD Specifications, Part A2, SD Host Controller
           Simplified Specification, Version 4.20
           URL: https://www.sdcard.org/downloads/pls/pdf/?p=PartA2_SD%20Host_Controller_Simplified_Specification_Ver4.20.jpg

Signed-off-by: Amneesh Singh <[email protected]>
Copy link

sonarqubecloud bot commented Oct 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Disk Access platform: ADI Analog Devices, Inc. platform: Ambiq Ambiq platform: ESP32 Espressif ESP32 platform: Infineon Infineon Technologies AG platform: NXP Drivers NXP Semiconductors, drivers platform: Renesas R-Car Renesas R-Car platform: Renesas RA Renesas Electronics Corporation, RA platform: Xilinx AMD Xilinx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants