Skip to content

Conversation

rruuaanng
Copy link
Contributor

For more to see #87662

Closes: #87662

@rruuaanng rruuaanng force-pushed the impr-dep-macro branch 2 times, most recently from bad5d4e to 7a8f165 Compare June 20, 2025 09:30
@rruuaanng rruuaanng marked this pull request as ready for review June 20, 2025 14:22
@github-actions github-actions bot added Release Notes To be mentioned in the release notes area: Toolchains Toolchains labels Jun 20, 2025
@rruuaanng rruuaanng requested a review from nashif June 21, 2025 01:43
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the warning message output by this macro is rather cryptic:

test.c:19:5: warning: 'foo' is deprecated: 4.3 [-Wdeprecated-declarations]

The message should be more clear to say something like "planned removal in v4.3"

Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update checkpatch attribute list:

our $Attribute = qr{

And would be nice to update tags.sh as well so that these show up in the same way as __deprecated:

-I __acquires,__releases,__deprecated \

@rruuaanng rruuaanng changed the title toolchain: Add the TOOLCHAIN_DEPRECATED macro toolchain: Add the __deprecated_version macro Jun 23, 2025
dkalowsk
dkalowsk previously approved these changes Jun 23, 2025
stephanosio
stephanosio previously approved these changes Jul 15, 2025
@stephanosio stephanosio added this to the v4.3.0 milestone Jul 15, 2025
keith-zephyr
keith-zephyr previously approved these changes Sep 15, 2025
@LoveKarlsson LoveKarlsson self-requested a review September 15, 2025 20:10
LoveKarlsson
LoveKarlsson previously approved these changes Sep 15, 2025
Add the `__deprecated_version` macro to print version
information when deprecation warnings are triggered.

Signed-off-by: James Roy <[email protected]>
Add the `__deprecated_version` macro to print version
information when deprecation warnings are triggered.

Signed-off-by: James Roy <[email protected]>
@rruuaanng rruuaanng force-pushed the impr-dep-macro branch 2 times, most recently from 2048da5 to 549896f Compare October 7, 2025 03:28
nashif
nashif previously approved these changes Oct 7, 2025
Add macro __deprecated_version to the checklists of
`scripts/checkpatch.pl` and `scripts/tags.sh`.

Signed-off-by: James Roy <[email protected]>
Add `__deprecated_version` macro to the Toolchain entry list.

Signed-off-by: James Roy <[email protected]>
Copy link

sonarqubecloud bot commented Oct 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Coding Guidelines Coding guidelines and style area: Linters area: Toolchains Toolchains Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the deprecation macro
10 participants