Skip to content

drivers: sensor: Add driver for MAX32664C #93674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drivers: sensor: Add driver for MAX32664C #93674

wants to merge 1 commit into from

Conversation

Kampi
Copy link
Contributor

@Kampi Kampi commented Jul 24, 2025 •
edited
Loading

  • Add driver for MAX32664 and MAX86141
  • Add sample project for MAX32664C as heart rate sensor

Open tasks:

  • Dynamic memory always crash with a kernel oops. Needs more debugging

Closes #93473

@Kampi Kampi marked this pull request as draft July 24, 2025 13:54
@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch 3 times, most recently from a1d609e to c7e80ce Compare July 28, 2025 06:50
@Kampi Kampi marked this pull request as ready for review July 28, 2025 06:51
@zephyrbot zephyrbot added the platform: ADI Analog Devices, Inc. label Jul 28, 2025
@Kampi
Copy link
Contributor Author

Kampi commented Jul 28, 2025

The basic functions for the driver are functional and can be tested. I set this PR as ready for review to start discussions / review about the code, especially the documentation and the sample.

There is no rush to approve it, because I´m still working on it. Hope this is okay :)

@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch 2 times, most recently from 13d7a97 to 3b3d487 Compare July 28, 2025 07:16
kartben
kartben reviewed Jul 28, 2025
View reviewed changes
@kartben kartben requested a review from Copilot July 28, 2025 07:24
Copilot

This comment was marked as outdated.

Sign in to view

@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch 3 times, most recently from 5a5a390 to 662155f Compare August 20, 2025 12:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarQube Cloud

@Kampi
Copy link
Contributor Author

Kampi commented Oct 1, 2025

@MaureenHelm do we have something open here?

MaureenHelm
MaureenHelm previously approved these changes Oct 3, 2025
View reviewed changes
@MaureenHelm
Copy link
Member

@yasinustunerg please revisit

@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch from 662155f to ca364f3 Compare October 9, 2025 12:51
@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch from ca364f3 to 1045f43 Compare October 9, 2025 20:19
@ttmut
Copy link
Contributor

ttmut commented Oct 10, 2025

Can you check the issues listed in SonarQube cloud?

Issues 18 New issues 0 Accepted issues

@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch 2 times, most recently from 5c47ed0 to bd1d090 Compare October 10, 2025 19:29
@Kampi Kampi requested a review from Copilot October 10, 2025 19:39
Copilot
Copilot AI reviewed Oct 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch 2 times, most recently from 6d6e024 to 76f5924 Compare October 10, 2025 20:59
@Kampi Kampi requested a review from Copilot October 10, 2025 21:41
Copilot
Copilot AI reviewed Oct 10, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch 2 times, most recently from e13d910 to 013bd9d Compare October 10, 2025 21:52
@Kampi
drivers: sensor: Add driver for MAX32664C
bb2a2c7 
- Add DTS for MAX32664C
- Add driver for MAX32664C
- Add example for MAX32664C Heart rate measurement with Bluetooth
- Add private attributes and channels for health measurement

Closes: zephyrproject-rtos#93473

Signed-off-by: Daniel Kampert <[email protected]>
@Kampi Kampi force-pushed the Add-Driver-for-MAX32664C branch from 013bd9d to bb2a2c7 Compare October 10, 2025 21:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@asemjonovs asemjonovs Awaiting requested review from asemjonovs

@avisconti avisconti Awaiting requested review from avisconti

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@nashif nashif Awaiting requested review from nashif

@teburd teburd Awaiting requested review from teburd

@tristan-google tristan-google Awaiting requested review from tristan-google

@ubieda ubieda Awaiting requested review from ubieda

@yperess yperess Awaiting requested review from yperess

@galak galak Awaiting requested review from galak

@microbuilder microbuilder Awaiting requested review from microbuilder

@ozersa ozersa Awaiting requested review from ozersa

@ttmut ttmut Awaiting requested review from ttmut

@yasinustunerg yasinustunerg Awaiting requested review from yasinustunerg

@kartben kartben Awaiting requested review from kartben

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

Requested changes must be addressed to merge this pull request.

Assignees

@MaureenHelm MaureenHelm

Labels

area: Boards/SoCs area: Devicetree Bindings area: Samples Samples area: Sensors Sensors platform: ADI Analog Devices, Inc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add driver support for MAX32664C / MAX86141

6 participants

@Kampi @ttmut @kartben @MaureenHelm @yasinustunerg @zephyrbot