You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @diegoherranz, very valid point. To limit flash usage for a very narrow and erroneous use case it's likely better to limit range to 0-59 and remove additional string warning.
tm_sec == 60 was accepted but it would only result in the time being
wrongly set (off by 1 second) since SYS_CLOCK_REALTIME is following
Unix time which doesn't support them.
Better to not accept them in the first place.
Signed-off-by: Diego Herranz <[email protected]>
Hi @diegoherranz, very valid point. To limit flash usage for a very narrow and erroneous use case it's likely better to limit range to 0-59 and remove additional string warning.
I believe the previous implementation was also fine. The date command is optional and only included when CONFIG_DATE_SHELL is enabled. If someone needs to save flash space, they can simply exclude it entirely.
The current change is also fine, but personally, I wouldn’t go too far with it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diegoherranz
force-pushed
the
date_leap_seconds
branch
from
SYS_CLOCK_REALTIME is following Unix time so, even if tm_sec == 60 is accepted, make very clear that leap seconds are not supported.