You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @NoahStephens, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊
Added support for the low side power switch pin used for switching
DUTs attached to the ADC. The switch is configured though the
drivers device tree.
Signed-off-by: Noah Stephens <[email protected]>
Fixed pd-switch-enable boolean logic description to the logic as
decribed in the data sheet for the device. Also fixed some code
compliance issues.
Signed-off-by: NoahStephens <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zephyrbot
added
area: ADC
NoahStephens
force-pushed
the
ad7124-pdsw-first-contrib
branch
from
Added support for the bridge power switch pin, controlled by the ADC7124 Control 1 register. The pin can be enabled though the device tree.
In the future pdsw_en could be switched on and off at run time, though the pm_runtime support.
Relevant Reference Materials
ADI AD7124-8 Product Page
AD7124-8 Data sheet (Rev E.) pdf
For specific information about
PDSWfunctionality refer toTable. 69 IO_CONTROL_1_REGISTERorBRIDGE POWER-DOWN SWITCHon page 48.