-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Bluetooth: Classic: add page/inquiry scan params and cod feature #96619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0a568c1
to
aff6b25
Compare
aff6b25
to
283560e
Compare
377c0de
to
91ecda9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengkai15 there's a "t" missing from the title of your second commit. Also, I'd recommend to familiarize yourself with https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-body and see if you think your commit messages need some improving :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks fine to me, but pay attention to code styles.
This commit implements Class of Device (COD) functionality for Classic Bluetooth, supporting both setting and retrieving COD from the controller by bt_br_write_cod and bt_br_read_cod. Signed-off-by: Kai Cheng <[email protected]>
This commit implements Class of Device (COD) test shell functionality for Classic Bluetooth, supporting both setting and retrieving COD from the controller. Signed-off-by: Kai Cheng <[email protected]>
Implement BR/EDR page scan parameters update functionality with new API bt_br_page_scan_update_param(). Adds support for setting page scan interval, window and type (standard/interlaced) via HCI commands. Includes predefined parameter sets for different Bluetooth versions and use cases. Signed-off-by: Kai Cheng <[email protected]>
91ecda9
to
81c6d6c
Compare
81c6d6c
to
2feafca
Compare
Add shell command for testing BR/EDR page scan parameters update. Supports predefined parameter sets (R0, R1, R2 variants) and custom parameters via interval/window/type arguments. Signed-off-by: Kai Cheng <[email protected]>
Implement BR/EDR inquiry scan parameters update functionality with new API bt_br_inquiry_scan_update_param(). Adds support for setting inquiry scan interval, window and type via HCI commands. Includes default parameter set for standard inquiry scanning. Signed-off-by: Kai Cheng <[email protected]>
Add shell command for testing BR/EDR inquiry scan parameters update. Supports default parameter set and custom parameters via interval/ window/type arguments for inquiry scan configuration. Signed-off-by: Kai Cheng <[email protected]>
2feafca
to
89e4936
Compare
|
This PR adds support for configuring BR/EDR page scan and inquiry scan parameters, and Class of Device (COD) features.
Changes
Page Scan Parameters:
bt_br_page_scan_update_param
API to update page scan interval, window, and type (standard or interlaced).Inquiry Scan Parameters:
bt_br_inquiry_scan_update_param
API to update inquiry scan interval, window, and type.Class of Device (COD):
Shell Commands:
pscan-param
shell command for testing page scan parameters.iscan-param
shell command for testing inquiry scan parameters.Testing
Notes
These features are essential for optimizing Bluetooth classic device discoverability and connectivity, and for correctly advertising the device class.