Series 2 i2c driver enhancements #96816
Open
+95
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_silabs
DNM (manifest)
fimohame
force-pushed
the
series-2-i2c-driver-enhancements
branch
from
aae5758 to
9dffddd
Compare
github-actions
bot
removed
manifest
manifest-hal_silabs
DNM (manifest)
fimohame
force-pushed
the
series-2-i2c-driver-enhancements
branch
from
9dffddd to
2a2c685
Compare
github-actions
bot
added
manifest
manifest-hal_silabs
DNM (manifest)
fimohame
force-pushed
the
series-2-i2c-driver-enhancements
branch
from
2a2c685 to
b8c8b0c
Compare
This commit updates the hal_silabs revision Signed-off-by: S Mohamed Fiaz <[email protected]>
fimohame
force-pushed
the
series-2-i2c-driver-enhancements
branch
from
b8c8b0c to
1823222
Compare
zephyrbot
requested review from
asmellby,
jerome-pouiller,
jhedberg,
Martinhoff-maker,
rettichschnidi,
teburd and
yonsch
asmellby
requested changes
Oct 6, 2025
drivers/i2c/i2c_silabs.c
Outdated
| static const struct i2c_silabs_dev_config i2c_silabs_dev_config_##idx = { \ | ||
| .pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(idx), \ | ||
| .base = (I2C_TypeDef *)DT_INST_REG_ADDR(idx), \ | ||
| .peripheral = SL_PERIPHERAL_I2C##idx, \ |
There was a problem hiding this comment.
This doesn't work, the devicetree index doesn't need to match the peripheral instance number. You need to construct a sl_peripheral_t from the reg and clocks data from devicetree. We cannot use the predefined ones from SiSDK in Zephyr.
There was a problem hiding this comment.
I've addressed the comment
fimohame
force-pushed
the
series-2-i2c-driver-enhancements
branch
from
1823222 to
584964c
Compare
Updated the I2C driver for EFR Series 2 devices based on the design improvements in the GSDK I2C implementation Signed-off-by: S Mohamed Fiaz <[email protected]>
fimohame
force-pushed
the
series-2-i2c-driver-enhancements
branch
from
584964c to
d4d90fb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the I2C driver for EFR Series 2 devices based on the design improvements in the GSDK I2C implementation