video: Patch SDMA & capture sample to arbitrate height and width #96986

zacck · 2025-10-03T16:14:22Z

The video capture sample does not work when using a combination of the FRDM-MCXN236 and the OV5640 camera and this is due to the sensor and the underlying interface having different defaults. This patch sets the interface resolution to that selected by the sample which in turn is set in the CONFIG.

JarmouniA

Please split this into 2 commits: driver changes, sample changes.
Also, explain why the driver change is needed in the commit message.

zacck · 2025-10-03T19:31:50Z

Please split this into 2 commits: driver changes, sample changes. Also, explain why the driver change is needed in the commit message.

Thank you, this is done.

drivers/video/video_mcux_smartdma.c

ngphibang

Could you confirm again this sole commit fixes the issue? I don't have HW to test.

zacck · 2025-10-09T09:27:05Z

Could you confirm again this sole commit fixes the issue? I don't have HW to test.

Last I checked as stated on discord, no this does not, one needs the samples changes as well.

zacck · 2025-10-09T09:28:20Z

I’ll be at my lab in a couple of hours and will share the results.

drivers/video/video_mcux_smartdma.c

avolmat-st · 2025-10-09T10:53:23Z

(oups, went too fast looking at previous comments, actually mine are close to some already made by @josuah)

josuah · 2025-10-09T10:58:42Z

Adding a DNM flag that can be removed as soon as #96986 (comment) is ok

zacck · 2025-10-09T11:58:25Z

Could you confirm again this sole commit fixes the issue? I don't have HW to test.

@ngphibang ok here are the results

without the samples commit

*** Booting Zephyr OS build v4.2.0-4814-gbafe2fbba202 ***
[00:00:00.125,000] <inf> main: Video device: video-sdma
[00:00:00.125,000] <inf> main: - Capabilities:
[00:00:00.125,000] <inf> main:   RGBP width [320; 320; 0] height [240; 240; 0]
[00:00:00.125,000] <inf> main: - Video format: RGBP 1280x720
[00:00:00.125,000] <err> nxp_video_sdma: Unsupported format
[00:00:00.125,000] <err> main: Unable to set format

with the samples commit

*** Booting Zephyr OS build v4.2.0-5041-gd0069f2abe68 ***
[00:00:00.125,000] <inf> main: Video device: video-sdma
[00:00:00.125,000] <inf> main: - Capabilities:
[00:00:00.125,000] <inf> main:   RGBP width [320; 320; 0] height [240; 240; 0]
[00:00:00.125,000] <inf> main: - Video format: RGBP 320x240
[00:00:00.139,000] <inf> main: - Supported frame intervals for the default format:
[00:00:00.139,000] <inf> main: - Supported controls:
[00:00:00.139,000] <inf> main:          device: ov5640@3c
[00:00:00.139,000] <inf> video_ctrls:                       Brightness 0x00980900 (int)    (flags=0x00) : min=-15 max=15 step=1 default=0 value=0
[00:00:00.139,000] <inf> video_ctrls:                         Contrast 0x00980901 (int)    (flags=0x00) : min=0 max=255 step=1 default=0 value=0
[00:00:00.139,000] <inf> video_ctrls:                       Saturation 0x00980902 (int)    (flags=0x00) : min=0 max=255 step=1 default=64 value=64
[00:00:00.139,000] <inf> video_ctrls:                              Hue 0x00980903 (int)    (flags=0x00) : min=0 max=359 step=1 default=0 value=0
[00:00:00.139,000] <inf> video_ctrls:                  Gain, Automatic 0x00980912 (bool)   (flags=0x10) : min=0 max=1 step=1 default=1 value=1
[00:00:00.139,000] <inf> video_ctrls:                  Horizontal Flip 0x00980914 (bool)   (flags=0x00) : min=0 max=1 step=1 default=0 value=0
[00:00:00.139,000] <inf> video_ctrls:                    Vertical Flip 0x00980915 (bool)   (flags=0x00) : min=0 max=1 step=1 default=0 value=0
[00:00:00.139,000] <inf> video_ctrls:             Power Line Frequency 0x00980918 (menu)   (flags=0x00) : min=0 max=3 step=1 default=1 value=1
[00:00:00.140,000] <inf> video_ctrls:                                  0: Disabled
[00:00:00.140,000] <inf> video_ctrls:                                  1: 50 Hz
[00:00:00.140,000] <inf> video_ctrls:                                  2: 60 Hz
[00:00:00.140,000] <inf> video_ctrls:                                  3: Auto
[00:00:00.140,000] <inf> video_ctrls:                    Analogue Gain 0x009e0903 (int)    (flags=0x0c) : min=0 max=1023 step=1 default=0 value=16
[00:00:00.140,000] <inf> video_ctrls:                       Pixel Rate 0x009f0902 (int64)  (flags=0x01) : min=24000000 max=96000000 step=1 default=48000000 value=24000000
[00:00:00.140,000] <inf> video_ctrls:                     Test Pattern 0x009f0903 (menu)   (flags=0x00) : min=0 max=4 step=1 default=0 value=0
[00:00:00.140,000] <inf> video_ctrls:                                  0: Disabled
[00:00:00.140,000] <inf> video_ctrls:                                  1: Color bars
[00:00:00.140,000] <inf> video_ctrls:                                  2: Color bars with rolling bar
[00:00:00.140,000] <inf> video_ctrls:                                  3: Color squares
[00:00:00.140,000] <inf> video_ctrls:                                  4: Color squares with rolling bar
[00:00:00.140,000] <inf> main: Capture started

cc @josuah @avolmat-st

let me know if I should add back the samples commit

avolmat-st · 2025-10-09T12:14:49Z

cc @josuah @avolmat-st

let me know if I should add back the samples commit

Do you mean the 2 proposals I mentioned above in the driver ? Well if that's easy and you have possibility to do that, why not ;)
Those are not blocking remarks so that is up to you.

zacck · 2025-10-09T12:21:03Z

cc @josuah @avolmat-st
let me know if I should add back the samples commit

Do you mean the 2 proposals I mentioned above in the driver ? Well if that's easy and you have possibility to do that, why not ;) Those are not blocking remarks so that is up to you.

Oh no no, your comments I will add but there is a commit that we are unclear on it looks like below

/frdm_mcxn236.conf
index 0f4576e59d1..ad449bf981a 100644
--- a/samples/drivers/video/capture/boards/frdm_mcxn236.conf
+++ b/samples/drivers/video/capture/boards/frdm_mcxn236.conf
@@ -1 +1,3 @@
 CONFIG_VIDEO_BUFFER_POOL_SZ_MAX=40000
+CONFIG_VIDEO_FRAME_WIDTH=320
+CONFIG_VIDEO_FRAME_HEIGHT=240

I am positive this is needed but Phi thinks otherwise and I do trust he knows why but I cant seem to make it work without this.

drivers/video/video_mcux_smartdma.c

zacck · 2025-10-13T04:50:54Z

@avolmat-st @ngphibang @josuah I would appreciate another review round I think I applied all the required changes.

ngphibang

Although the 2nd commit is not really needed for the capture sample, configuring the frame width & height is still OK to ensure that if, for some reason, the sample application does not get the format before setting the format, it's still working.

BTW, could you change the commits title, to something like :

drivers: video: mcux_sdma: Reconfigure the source when getting format
Reconfigure the sensor format with the only supported format of the sdma when getting format

samples: video: capture: Configure frame width and heght for mcxn236

Thanks !

zacck · 2025-10-13T10:10:53Z

Although the 2nd commit is not really needed for the capture sample, configuring the frame width & height is still OK to ensure that if, for some reason, the sample application does not get the format before setting the format, it's still working.

BTW, could you change the commits title, to something like :
drivers: video: mcux_sdma: Reconfigure the source when getting format
Reconfigure the sensor format with the only supported format of the sdma when getting format
samples: video: capture: Configure frame width and heght for mcxn236

Thanks !

Can do!

Reconfigure the sensor format with the only supported format of the sdma when getting format Signed-off-by: Zacck Osiemo <[email protected]>

SDMA as the video interface on this board requires this size frame to be set for the sample to work Signed-off-by: Zacck Osiemo <[email protected]>

sonarqubecloud · 2025-10-13T16:51:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ngphibang

The 2nd commit message needs a bit rewording but not a big problem to me. Thanks.

josuah

Thanks for the commits/testing/bugfix!
This will help working with more sensors.

josuah · 2025-10-15T17:23:25Z

samples/drivers/video/capture/boards/frdm_mcxn236.conf

Some light commit message rewording could be:

**With** SDMA as the video interface on this board**, it** requires **the frame size** to be set for the sample to work

ngphibang · 2025-10-16T08:23:50Z

Removed DNM label as it seems @josuah has approved but forgot to do it.

github-actions · 2025-10-16T16:18:20Z

Hi @zacck!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added platform: NXP NXP area: Video Video subsystem area: Samples Samples labels Oct 3, 2025

zephyrbot requested review from JarmouniA, avolmat-st, dbaluta, decsny, dleach02, josuah, kartben, loicpoulain, manuargue, mmahadevan108, nashif and ngphibang October 3, 2025 16:16

zephyrbot assigned josuah and ngphibang Oct 3, 2025

zacck force-pushed the pr-patch-sdma-for-mcxn236 branch from 85af2ed to 91be28e Compare October 3, 2025 16:26

JarmouniA reviewed Oct 3, 2025

View reviewed changes

zacck force-pushed the pr-patch-sdma-for-mcxn236 branch from 91be28e to bafe2fb Compare October 3, 2025 19:31

zacck force-pushed the pr-patch-sdma-for-mcxn236 branch from bafe2fb to aa93037 Compare October 6, 2025 05:19

josuah reviewed Oct 7, 2025

View reviewed changes

drivers/video/video_mcux_smartdma.c Show resolved Hide resolved

zacck force-pushed the pr-patch-sdma-for-mcxn236 branch from aa93037 to d0069f2 Compare October 8, 2025 15:56

ngphibang previously approved these changes Oct 9, 2025

View reviewed changes

josuah self-requested a review October 9, 2025 08:29

avolmat-st reviewed Oct 9, 2025

View reviewed changes

drivers/video/video_mcux_smartdma.c Outdated Show resolved Hide resolved

drivers/video/video_mcux_smartdma.c Outdated Show resolved Hide resolved

josuah added the DNM This PR should not be merged (Do Not Merge) label Oct 9, 2025

avolmat-st reviewed Oct 9, 2025

View reviewed changes

drivers/video/video_mcux_smartdma.c Outdated Show resolved Hide resolved

zacck dismissed ngphibang’s stale review via 9d964a7 October 13, 2025 04:49

zacck force-pushed the pr-patch-sdma-for-mcxn236 branch from d0069f2 to 9d964a7 Compare October 13, 2025 04:49

ngphibang requested changes Oct 13, 2025

View reviewed changes

zacck force-pushed the pr-patch-sdma-for-mcxn236 branch from 9d964a7 to 2ca712a Compare October 13, 2025 10:14

zacck added 2 commits October 13, 2025 18:23

drivers: video: mcux_sdma: Reconfigure the source when getting format

41f1de1

Reconfigure the sensor format with the only supported format of the sdma when getting format Signed-off-by: Zacck Osiemo <[email protected]>

samples: video: capture: Configure frame width and heght for mcxn236

f059ace

SDMA as the video interface on this board requires this size frame to be set for the sample to work Signed-off-by: Zacck Osiemo <[email protected]>

zacck force-pushed the pr-patch-sdma-for-mcxn236 branch from 2ca712a to f059ace Compare October 13, 2025 16:26

zacck requested a review from ngphibang October 13, 2025 16:28

ngphibang approved these changes Oct 13, 2025

View reviewed changes

ngphibang requested review from josuah and removed request for josuah October 13, 2025 17:20

josuah approved these changes Oct 15, 2025

View reviewed changes

josuah reviewed Oct 15, 2025

View reviewed changes

ngphibang removed the DNM This PR should not be merged (Do Not Merge) label Oct 16, 2025

ngphibang added this to the v4.3.0 milestone Oct 16, 2025

cfriedt merged commit 7f6937d into zephyrproject-rtos:main Oct 16, 2025
27 checks passed

video: Patch SDMA & capture sample to arbitrate height and width #96986

video: Patch SDMA & capture sample to arbitrate height and width #96986

Conversation

zacck commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JarmouniA left a comment

Choose a reason for hiding this comment

Uh oh!

zacck commented Oct 3, 2025

Uh oh!

Uh oh!

ngphibang left a comment

Choose a reason for hiding this comment

Uh oh!

zacck commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zacck commented Oct 9, 2025

Uh oh!

Uh oh!

Uh oh!

avolmat-st commented Oct 9, 2025

Uh oh!

josuah commented Oct 9, 2025

Uh oh!

zacck commented Oct 9, 2025

Uh oh!

avolmat-st commented Oct 9, 2025

Uh oh!

zacck commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

zacck commented Oct 13, 2025

Uh oh!

ngphibang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zacck commented Oct 13, 2025

Uh oh!

sonarqubecloud bot commented Oct 13, 2025

Quality Gate passed

Uh oh!

ngphibang left a comment

Choose a reason for hiding this comment

Uh oh!

josuah left a comment

Choose a reason for hiding this comment

Uh oh!

josuah Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ngphibang commented Oct 16, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zacck commented Oct 3, 2025 •

edited

Loading

zacck commented Oct 9, 2025 •

edited

Loading

zacck commented Oct 9, 2025 •

edited

Loading

ngphibang left a comment •

edited

Loading

josuah Oct 15, 2025 •

edited

Loading