Skip to content

Conversation

henrikbrixandersen
Copy link
Member

@henrikbrixandersen henrikbrixandersen commented Oct 4, 2025

Skip the mutex locking/unlocking when called during pre-kernel.

Skip the mutex locking/unlocking when called during pre-kernel.

Signed-off-by: Henrik Brix Andersen <[email protected]>
@henrikbrixandersen henrikbrixandersen force-pushed the retention_skip_mutex_in_pre_kernel branch from f478893 to 39fe351 Compare October 4, 2025 16:53
Copy link

sonarqubecloud bot commented Oct 4, 2025

Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why this change is needed in the commit message?

@henrikbrixandersen henrikbrixandersen marked this pull request as draft October 4, 2025 18:30
@henrikbrixandersen henrikbrixandersen marked this pull request as ready for review October 4, 2025 20:25
@henrikbrixandersen henrikbrixandersen marked this pull request as draft October 4, 2025 20:26
@henrikbrixandersen
Copy link
Member Author

Could you explain why this change is needed in the commit message?

Yeah, sorry - meant to open this as a draft, but the GH UI is playing tricks on me.

This PR is not complete as the retention system is currently initialized post-kernel, so the mutex will always be used as-is. The discussion leading up to this is taking place in the linked #84272 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants