samples: boards: nordic: spis_wakeup: Fix sample on nrf54h20 #97044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing property to spi130 node. Add `zephyr,pm-device-runtime-auto` since the sample enables PM. Signed-off-by: Sebastian Głąb <[email protected]>
zephyrbot
added
size: XS
zephyrbot
requested review from
anangl,
bjarki-andreasen,
JarmouniA,
jaz1-nordic,
kartben,
kl-cruz,
lstnl,
magp-nordic,
masz-nordic,
nashif and
nika-nordic
|
nordic-piks
approved these changes
Oct 6, 2025
|
Sample works in internal CI |
anangl
approved these changes
Oct 6, 2025
|
zephyr/soc/nordic/common/Kconfig.defconfig Lines 10 to 11 in 9ae10ea |
I see it was added in this PR However, it's not present in sdk-zephyr Do You know when this change will be added in NCS? |
|
That is being worked on here nrfconnect/sdk-zephyr#3314 so hopefully soon, though until then this PR has no negative impact so we can merge this now no problem |
bjarki-andreasen
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing property to spi130 node.
Add
zephyr,pm-device-runtime-autosince the sample enables PM.