You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case where there are multiple different kinds of UART on one platform, the other UART driver select SERIAL_SUPPORT_ASYNC but LPUART did not, causing build error in LPUART driver. Shield LPUART driver from this case by introducing driver config to indicate that in fact LPUART is the one enabling ASYNC.
Handle the case where there are multiple different kinds of UART on one
platform, the other UART driver select SERIAL_SUPPORT_ASYNC but LPUART
did not, causing build error in LPUART driver. Shield LPUART driver from
this case by introducing driver config to indicate that in fact LPUART
is the one enabling ASYNC.
Signed-off-by: Declan Snyder <[email protected]>
how is this a hotfix? please do not use hotfix for bug fixes, hotfix should only be used for serious CI issues that block overall development, not a breakage on some hardware being tested downstream.
how is this a hotfix? please do not use hotfix for bug fixes, hotfix should only be used for serious CI issues that block overall development, not a breakage on some hardware being tested downstream.
It was blocking CI, did you read the description of the PR where I said it's fixing CI issues? it's not a hardware failure, it's a build failure, see linked issue. In fact I think honestly we don't care if this led strip sample fails on hardware very much at all
Although we probably could remove the hotfix now due to some other hotfix went in for the same issue I think, but originally this was a hotfix due to many PR blocked by CI due to this issue @nashif
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decsny
added
the
Hotfix
zephyrbot
added
area: UART
nashif
removed
the
Hotfix
Handle the case where there are multiple different kinds of UART on one platform, the other UART driver select SERIAL_SUPPORT_ASYNC but LPUART did not, causing build error in LPUART driver. Shield LPUART driver from this case by introducing driver config to indicate that in fact LPUART is the one enabling ASYNC.
Fixing CI issue for example on #96983
Might fix #97022 , not sure @hakehuang ?