drivers: sensors: bmp581: fix temperature scaling #97083
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
maxmclau
force-pushed
the
bmp581-temp-negative-fix
branch
from
0d2105c to
b33746c
Compare
This change fixes and issue where negative temperatures wrap and return 250C when the sensor gets below zero. The implementation is pulled from Boschs official BMP5_SensorAPI and has been tested to work down to -40. Signed-off-by: Maxmillion McLaughlin <[email protected]>
maxmclau
force-pushed
the
bmp581-temp-negative-fix
branch
from
b33746c to
a85567f
Compare
|
ubieda
reviewed
Oct 7, 2025
Comment on lines
+408
to
+414
| /* convert raw sensor data to sensor_value. | ||
| * BMP581 temperature data is 24-bit signed with LSB = 1/65536 °C | ||
| */ | ||
| drv->last_sample.temperature.val1 = data[2]; | ||
| drv->last_sample.temperature.val2 = (data[1] << 8 | data[0]) * 10; | ||
| int32_t raw_temp = ((int32_t)((uint32_t)(((uint32_t)data[2] << 16) | | ||
| ((uint16_t)data[1] << 8) | data[0]) | ||
| << 8) >> | ||
| 8); |
There was a problem hiding this comment.
Instead of shifting 8 up and 8 down, I suggest using sign_extend(), similar to how it's done in the decoder:
zephyr/drivers/sensor/bosch/bmp581/bmp581_decoder.c
Lines 125 to 130 in ca85e76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes and issue where negative temperatures wrap and return 250C when the sensor gets below zero. The implementation is pulled from Boschs official BMP5_SensorAPI and has been tested to work down to -40.