storage: flash_map: deprecate legacy Mbed TLS crypto #97605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Storage
valeriosetti
force-pushed
the
flash-map-deprecate-legacy-crypto
branch
from
000762e to
c86ad3d
Compare
maass-hamburg
requested changes
Oct 15, 2025
subsys/storage/flash_map/Kconfig
Outdated
|
|
||
| config FLASH_AREA_CHECK_INTEGRITY_PSA | ||
| bool "Use PSA" | ||
| select PSA_WANT_ALG_SHA_256 | ||
| select MBEDTLS if !BUILD_WITH_TFM | ||
| select MBEDTLS_PSA_CRYPTO_C if !BUILD_WITH_TFM | ||
| select PSA_WANT_ALG_SHA_256 if !BUILD_WITH_TFM |
There was a problem hiding this comment.
there is already a select PSA_WANT_ALG_SHA_256 before
valeriosetti
force-pushed
the
flash-map-deprecate-legacy-crypto
branch
from
c86ad3d to
2259aec
Compare
jhedberg
reviewed
Oct 15, 2025
subsys/storage/flash_map/Kconfig
Outdated
| help | ||
| Use the PSA API to perform the integrity check. | ||
|
|
||
| config FLASH_AREA_CHECK_INTEGRITY_MBEDTLS | ||
| bool "Use Mbed TLS" | ||
| bool "[DEPRECATED] Use Mbed TLS" |
There was a problem hiding this comment.
Is there some existing guidance on how "[DEPRECATED]" should be formatted in the Kconfig description? It seems like it's more common to put it at the end of the string rather than the beginning:
❯ git grep '"\[DEPRECATED\] '|wc -l
3
❯ git grep ' \[DEPRECATED\]"'|wc -l
15
2259aec to
00228e5
Compare
maass-hamburg
previously approved these changes
Oct 16, 2025
valeriosetti
force-pushed
the
flash-map-deprecate-legacy-crypto
branch
from
00228e5 to
8310309
Compare
The long-term goal of the Zephyr project is to rely exclusively on PSA Crypto API for the crypto support. In parallel Mbed TLS is going to remove legacy crypto support from the next (4.0) release. Therefore this commit deprecates CONFIG_FLASH_AREA_CHECK_INTEGRITY_MBEDTLS and it also updates the migration guide document about this change. Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
flash-map-deprecate-legacy-crypto
branch
from
8310309 to
7df3ee4
Compare
|
The double force push is intentional:
|
maass-hamburg
approved these changes
Oct 17, 2025
|
jhedberg
approved these changes
Oct 17, 2025
cfriedt
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long-term goal of the Zephyr project is to rely exclusively on PSA Crypto API for the crypto support. In parallel Mbed TLS is going to remove legacy crypto support from the next (4.0) release.
Therefore this PR deprecates CONFIG_FLASH_AREA_CHECK_INTEGRITY_MBEDTLS and it also updates the migration guide document about this change.