driver: i2c: i2c_ll_stm32: add error handling in i2c_stm32_error for I2C target mode #97810
+127
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juickar
force-pushed
the
fix_i2c_error_cb
branch
3 times, most recently
from
6d4e53f to
4ab03bc
Compare
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
teburd
etienne-lms
requested changes
Oct 22, 2025
There was a problem hiding this comment.
I think you should add you're S-o-b tag to the commits in additions to @kbidani's one.
| #endif | ||
| goto end; | ||
| } | ||
|
|
There was a problem hiding this comment.
end sequence must be updated:
end:
+#if defined(CONFIG_I2C_TARGET)
+ if (data->slave_attached && !data->master_active) {
+ return -EIO;
+ }
+#endif
i2c_stm32_disable_transfer_interrupts(dev);
/* Wakeup thread */
k_sem_give(&data->device_sync_sem);
return -EIO;
}(with indentation updates)
drivers/i2c/i2c_ll_stm32_v2.c
Outdated
| data->current.is_arlo = 1U; | ||
| #if defined(CONFIG_I2C_TARGET) | ||
| if (error_cb != NULL) { | ||
| error_cb(data->slave_cfg, I2C_ERROR_GENERIC); |
Support I2C target error callback in I2C driver when registered by the bus target consumer. Signed-off-by: Khaoula Bidani <[email protected]> Signed-off-by: Julien Racki <[email protected]>
Allow applications to be notified of target I2C transfer error usingthe recently added target error callback mechanism. Signed-off-by: Khaoula Bidani <[email protected]> Signed-off-by: Julien Racki <[email protected]>
juickar
force-pushed
the
fix_i2c_error_cb
branch
from
4ab03bc to
d20a3b1
Compare
|
|
@teburd PTAL and advise if ok for V4.3.0 |
etienne-lms
approved these changes
Oct 24, 2025
teburd
approved these changes
Oct 24, 2025
erwango
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over #95984 as mentioned here
Main differences with the first PR are:
i2c_stm32_master_mode_endcalls fromdrivers/i2c/i2c_ll_stm32_v2.cbecause it has been removed with this commit.Fixes #92383