STM32: clean up inclusion of mem.h in SoC DTSI files
#97817
+24
−255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. There is no consistency about which level of the DTSI inclusion hierarchy the macros from this header start being used, so including it from the root file ensures they are always visible and available without headache. Today, there are places where the header is included twice or more at different DTSI inclusion hierarchy levels because of this ambiguity - this commit solves the issue once and for all. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
Include <mem.h> from the series' root DTSI file and remove inclusion of the file from other levels since it becomes redundant. This avoids the current situation where the same #include directive is duplicated among many files, and where the file is sometimes included multiple times when walking up the inclusion chain up until the root DTSI file. Signed-off-by: Mathieu Choplain <[email protected]>
zephyrbot
requested review from
FRASTM,
djiatsaf-st,
erwango,
etienne-lms and
gautierg-st
|
@erwango I'll let you tag with |
|
gautierg-st
approved these changes
Oct 20, 2025
etienne-lms
requested changes
Oct 20, 2025
| }; | ||
| }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
It seems your editor added an extra empty line here. Could you remove it?
There was a problem hiding this comment.
All other files seem to end with an empty newline so I think it's fine to keep it.
(I already noticed this but didn't edit PR for this reason)
There was a problem hiding this comment.
My bad, github fooled me, you don't add any empty line here.
etienne-lms
approved these changes
Oct 20, 2025
| }; | ||
| }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
My bad, github fooled me, you don't add any empty line here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
<mem.h>from the root DTSI in all series and remove it from other levels of the DTSI inclusion hierarchy. This cleans up some duplicate inclusions and is just more maintainable in the long term (especially since new series copy the existing bad pattern).STM32WB0, STM32MP1, STM32MP13 and STM32MP2 are not modified because they already include
<mem.h>from root.