driver: wifi: esp32: add driver set_config interface #98764
Draft
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
reviewed
Nov 3, 2025
Comment on lines
905
to
909
| esp_err_t ret = esp_wifi_set_mac(WIFI_IF_STA, dev_data->mac_addr); | ||
|
|
||
| if (ret != ESP_OK) { | ||
| printk("Failed to set mac address: %d\n", ret); | ||
| } |
Member
There was a problem hiding this comment.
I think it would be better if we call
memcpy(dev_data->mac_addr, config->mac_address.addr, 6);
net_if_set_link_addr(esp32_wifi_iface, dev_data->mac_addr,
sizeof(dev_data->mac_addr), NET_LINK_ETHERNET);
after the esp_wifi_set_mac() has succeeded. Otherwise if the call fails, we have inconsistent mac address in upper net stack compared to esp32 driver.
Contributor
Author
There was a problem hiding this comment.
Hi, I will update/polish this once the user confirms it works on his side. Thanks for the suggestion.
Contributor
Author
There was a problem hiding this comment.
Well, let's update it now.
Allows set the device macaddress. > net iface set_mac 1 aa:bb:cc:dd:ee:ff > wifi connect -s ssid -p password -k 1 Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
feature/esp32-wifi-macaddr-l2
branch
from
93f2f8c to
e0b95bf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows set the device macaddress.