Skip to content

[Bug ๐Ÿž]: Incorrect syntax in patch results in double patchย #103

@linuxgurugamer

Description

@linuxgurugamer

Brief description of your issue (aka the problem)

The patches you have for this mod are broken, they are being run two times, resulting in some double entries. This can be seen in the following image, where the title has the ODFC in the title in indigo two times:

https://i.imgur.com/bLl6SWn.png

and when I looked at the ModuleManager logs, I see the following:

`[LOG 19:32:42.484] Applying update OnDemandFuelCells/Config/LargeCrewedLab/@part[Large?Crewed?Lab]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]

[LOG 19:32:42.486] Applying update OnDemandFuelCells/Config/StockFuelCells/@part[FuelCell,FuelCellArray]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Resources/FuelCell/FuelCell.cfg/PART[FuelCell]

[LOG 19:32:42.487] Applying update OnDemandFuelCells/Config/StockFuelCells/@part[FuelCell,FuelCellArray]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Resources/FuelCell/FuelCellArray.cfg/PART[FuelCellArray]

[LOG 19:32:42.491] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/cupola/cupola.cfg/PART[cupola]

[LOG 19:32:42.491] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/hitchhikerStorageContainer/hitchikerStorageContainer.cfg/PART[crewCabin]

[LOG 19:32:42.491] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/Mk1-3Pod/mk1-3.cfg/PART[mk1-3pod]

[LOG 19:32:42.492] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/mk1LanderCan/mk1LanderCan.cfg/PART[landerCabinSmall]

[LOG 19:32:42.492] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/mk1pod_v2/mk1Pod_v2.cfg/PART[mk1pod_v2]

[LOG 19:32:42.492] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/mk2LanderCan/mk2LanderCan.cfg/PART[mk2LanderCabin]

[LOG 19:32:42.492] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/mk3CockpitShuttle/mk3CockpitShuttle.cfg/PART[mk3Cockpit_Shuttle]

[LOG 19:32:42.496] :AFTER[ONDEMANDFUELCELLS] pass

[LOG 19:32:42.497] Applying update OnDemandFuelCells/Compatibility/ReStockPlus/@part[restock-apu-radial-1]:NEEDS[OnDemandFuelCells,RestockPlus]:AFTER[OnDemandFuelCells] to ReStockPlus/Parts/Electrical/radial/restock-apu-radial-1.cfg/PART[restock-apu-radial-1]

[LOG 19:32:42.500] Applying update OnDemandFuelCells/Compatibility/ReStockPlus/@part[restock-apu-radial-1]:NEEDS[OnDemandFuelCells,RestockPlus]:AFTER[OnDemandFuelCells] to ReStockPlus/Parts/Electrical/radial/restock-apu-radial-1.cfg/PART[restock-apu-radial-1]

[LOG 19:32:42.510] Applying update OnDemandFuelCells/Compatibility/UniversalStorage2/@part[USFuelCellSmal]:NEEDS[UniversalStorage2,OnDemandFuelCells]:AFTER[OnDemandFuelCells] to UniversalStorage2/Parts/Electrical/FuelCellSmall.cfg/PART[USFuelCellSmal]

[LOG 19:32:42.514] Applying update OnDemandFuelCells/Compatibility/UniversalStorage2/@part[USFuelCellMedium]:NEEDS[UniversalStorage2,OnDemandFuelCells]:AFTER[OnDemandFuelCells] to UniversalStorage2/Parts/Electrical/FuelCellMedium.cfg/PART[USFuelCellMedium]

[LOG 19:32:42.516] Applying update OnDemandFuelCells/Config/LargeCrewedLab/@part[Large_Crewed_Lab]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]

[LOG 19:32:42.522] Applying update OnDemandFuelCells/Config/StockFuelCells/@part[FuelCell]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Resources/FuelCell/FuelCell.cfg/PART[FuelCell]

[LOG 19:32:42.525] Applying update OnDemandFuelCells/Config/StockFuelCells/@part[FuelCellArray]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Resources/FuelCell/FuelCellArray.cfg/PART[FuelCellArray]

[LOG 19:32:42.537] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/cupola/cupola.cfg/PART[cupola]

[LOG 19:32:42.538] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/hitchhikerStorageContainer/hitchikerStorageContainer.cfg/PART[crewCabin]

[LOG 19:32:42.539] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/Mk1-3Pod/mk1-3.cfg/PART[mk1-3pod]

[LOG 19:32:42.540] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/mk1LanderCan/mk1LanderCan.cfg/PART[landerCabinSmall]

[LOG 19:32:42.541] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/mk1pod_v2/mk1Pod_v2.cfg/PART[mk1pod_v2]

[LOG 19:32:42.541] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/mk2LanderCan/mk2LanderCan.cfg/PART[mk2LanderCabin]

[LOG 19:32:42.542] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/mk3CockpitShuttle/mk3CockpitShuttle.cfg/PART[mk3Cockpit_Shuttle]

`

The fix is to remove this:

:FOR[OnDemandFuelCells]

which is not needed and, as you can see, results in the patch being applied two times

Operating system

Win 10

KSP version

1.12.5

Version of addon

1.2.99.0pre

Steps to reproduce the behavior or issue

Install mod
Run game
View part in editor

Expected behavior

The patch should only run one time, not two times

Actual behavior

No response

Environment

ODFC: 1.2.99.0pre
Downloaded from SpaceDock (specifying the latest version)

Log files

[LOG 19:32:42.484] Applying update OnDemandFuelCells/Config/LargeCrewedLab/@part[Large?Crewed?Lab]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]

[LOG 19:32:42.486] Applying update OnDemandFuelCells/Config/StockFuelCells/@part[FuelCell,FuelCellArray]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Resources/FuelCell/FuelCell.cfg/PART[FuelCell]

[LOG 19:32:42.487] Applying update OnDemandFuelCells/Config/StockFuelCells/@part[FuelCell,FuelCellArray]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Resources/FuelCell/FuelCellArray.cfg/PART[FuelCellArray]

[LOG 19:32:42.491] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/cupola/cupola.cfg/PART[cupola]

[LOG 19:32:42.491] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/hitchhikerStorageContainer/hitchikerStorageContainer.cfg/PART[crewCabin]

[LOG 19:32:42.491] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/Mk1-3Pod/mk1-3.cfg/PART[mk1-3pod]

[LOG 19:32:42.492] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/mk1LanderCan/mk1LanderCan.cfg/PART[landerCabinSmall]

[LOG 19:32:42.492] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/mk1pod_v2/mk1Pod_v2.cfg/PART[mk1pod_v2]

[LOG 19:32:42.492] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/mk2LanderCan/mk2LanderCan.cfg/PART[mk2LanderCabin]

[LOG 19:32:42.492] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:FOR[OnDemandFuelCells] to Squad/Parts/Command/mk3CockpitShuttle/mk3CockpitShuttle.cfg/PART[mk3Cockpit_Shuttle]

[LOG 19:32:42.496] :AFTER[ONDEMANDFUELCELLS] pass

[LOG 19:32:42.497] Applying update OnDemandFuelCells/Compatibility/ReStockPlus/@part[restock-apu-radial-1]:NEEDS[OnDemandFuelCells,RestockPlus]:AFTER[OnDemandFuelCells] to ReStockPlus/Parts/Electrical/radial/restock-apu-radial-1.cfg/PART[restock-apu-radial-1]

[LOG 19:32:42.500] Applying update OnDemandFuelCells/Compatibility/ReStockPlus/@part[restock-apu-radial-1]:NEEDS[OnDemandFuelCells,RestockPlus]:AFTER[OnDemandFuelCells] to ReStockPlus/Parts/Electrical/radial/restock-apu-radial-1.cfg/PART[restock-apu-radial-1]

[LOG 19:32:42.510] Applying update OnDemandFuelCells/Compatibility/UniversalStorage2/@part[USFuelCellSmal]:NEEDS[UniversalStorage2,OnDemandFuelCells]:AFTER[OnDemandFuelCells] to UniversalStorage2/Parts/Electrical/FuelCellSmall.cfg/PART[USFuelCellSmal]

[LOG 19:32:42.514] Applying update OnDemandFuelCells/Compatibility/UniversalStorage2/@part[USFuelCellMedium]:NEEDS[UniversalStorage2,OnDemandFuelCells]:AFTER[OnDemandFuelCells] to UniversalStorage2/Parts/Electrical/FuelCellMedium.cfg/PART[USFuelCellMedium]

[LOG 19:32:42.516] Applying update OnDemandFuelCells/Config/LargeCrewedLab/@part[Large_Crewed_Lab]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg/PART[Large_Crewed_Lab]

[LOG 19:32:42.522] Applying update OnDemandFuelCells/Config/StockFuelCells/@part[FuelCell]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Resources/FuelCell/FuelCell.cfg/PART[FuelCell]

[LOG 19:32:42.525] Applying update OnDemandFuelCells/Config/StockFuelCells/@part[FuelCellArray]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Resources/FuelCell/FuelCellArray.cfg/PART[FuelCellArray]

[LOG 19:32:42.537] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/cupola/cupola.cfg/PART[cupola]

[LOG 19:32:42.538] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/hitchhikerStorageContainer/hitchikerStorageContainer.cfg/PART[crewCabin]

[LOG 19:32:42.539] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/Mk1-3Pod/mk1-3.cfg/PART[mk1-3pod]

[LOG 19:32:42.540] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/mk1LanderCan/mk1LanderCan.cfg/PART[landerCabinSmall]

[LOG 19:32:42.541] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/mk1pod_v2/mk1Pod_v2.cfg/PART[mk1pod_v2]

[LOG 19:32:42.541] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/mk2LanderCan/mk2LanderCan.cfg/PART[mk2LanderCabin]

[LOG 19:32:42.542] Applying update OnDemandFuelCells/Config/StockPods/@part[crewCabin,mk1-3pod,landerCabinSmall,mk1pod,mk1pod_v2,mk2LanderCabin,mk2LanderCabin_V2,mk3Cockpit_Shuttle,cupola,mk2Pod]:NEEDS[OnDemandFuelCells]:AFTER[OnDemandFuelCells] to Squad/Parts/Command/mk3CockpitShuttle/mk3CockpitShuttle.cfg/PART[mk3Cockpit_Shuttle]

Screenshots

Image

Additional context

No response

How did you download and install this?

SpaceDock (manual install)

Metadata

Metadata

Labels

bug ๐Ÿ›An issue with the system. Something isn't working... KSC... we have an error codeissue: compatibility/patchissue typetype: fixIterations on existing features or infrastructure.

Projects

Status

In Progress

Relationships

None yet

Development

No branches or pull requests

Issue actions