fix: correct version handling error in SPIP check

Author: Chocapikk

modules/exploits/multi/http/spip_connect_exec.rb

@@ -77,24 +77,17 @@ def initialize(info = {})
   end
 
   def check
-    version = spip_version
+    rversion = spip_version
+    return Exploit::CheckCode::Unknown('Unable to determine the version of SPIP') unless rversion
 
-    print_status("SPIP Version detected: #{version}")
+    print_status("SPIP Version detected: #{rversion}")
 
-    rversion = Rex::Version.new(version)
-
-    if rversion >= Rex::Version.new('2.0.0')
-      if rversion < Rex::Version.new('2.0.21')
-        return Exploit::CheckCode::Appears
-      end
-    elsif rversion >= Rex::Version.new('2.1.0')
-      if rversion < Rex::Version.new('2.1.16')
-        return Exploit::CheckCode::Appears
-      end
-    elsif rversion >= Rex::Version.new('3.0.0')
-      if rversion < Rex::Version.new('3.0.3')
-        return Exploit::CheckCode::Appears
-      end
+    if rversion.between?(Rex::Version.new('2.0.0'), Rex::Version.new('2.0.20'))
+      return Exploit::CheckCode::Appears
+    elsif rversion.between?(Rex::Version.new('2.1.0'), Rex::Version.new('2.1.15'))
+      return Exploit::CheckCode::Appears
+    elsif rversion.between?(Rex::Version.new('3.0.0'), Rex::Version.new('3.0.2'))
+      return Exploit::CheckCode::Appears
     end
 
     return Exploit::CheckCode::Safe

modules/exploits/multi/http/spip_porte_plume_previsu_rce.rb

@@ -76,7 +76,8 @@ def check
     return Exploit::CheckCode::Unknown('Unable to determine the version of SPIP') unless rversion
 
     print_status("SPIP Version detected: #{rversion}")
-    if Rex::Version.new(rversion) > Rex::Version.new('4.2.12')
+
+    if rversion > Rex::Version.new('4.2.12')
       return CheckCode::Safe("The detected SPIP version (#{rversion}) is not vulnerable.")
     end
 

modules/exploits/multi/http/spip_rce_form.rb

@@ -80,13 +80,11 @@ def check
 
     print_status("SPIP Version detected: #{rversion}")
 
-    if rversion.between?(Rex::Version.new('4.2.0'), Rex::Version.new('4.2.1'))
+    if rversion.between?(Rex::Version.new('2.0.0'), Rex::Version.new('2.0.20'))
       return Exploit::CheckCode::Appears
-    elsif rversion.between?(Rex::Version.new('4.1.0'), Rex::Version.new('4.1.18'))
+    elsif rversion.between?(Rex::Version.new('2.1.0'), Rex::Version.new('2.1.15'))
       return Exploit::CheckCode::Appears
-    elsif rversion.between?(Rex::Version.new('4.0.0'), Rex::Version.new('4.0.10'))
-      return Exploit::CheckCode::Appears
-    elsif rversion.between?(Rex::Version.new('3.2.0'), Rex::Version.new('3.2.18'))
+    elsif rversion.between?(Rex::Version.new('3.0.0'), Rex::Version.new('3.0.2'))
       return Exploit::CheckCode::Appears
     end