Skip to content

Commit b67f05f

Browse files
authored
Apply suggestions from code review
1 parent 7e4c6ca commit b67f05f

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

modules/exploits/linux/http/zyxel_parse_config_rce.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ def initialize(info = {})
5252
register_options(
5353
[
5454
OptString.new('WRITABLE_DIR', [ true, 'A directory where we can write files', '/tmp' ]),
55-
OptBool.new('SHOW_CMD_OUTPUT', [true, 'When true the module will query the logs for the injected command\'s stdout', false])
5655
]
5756
)
5857
end
@@ -156,8 +155,8 @@ def exploit
156155
'data' => data.to_s
157156
})
158157

159-
# If the payload being used is for example cmd/unix/generic and not a payload spawning a reverse connection we can
160-
# query the /ztp/cgi-bin/dumpztplog.py for the stdout of the command and print it for the user.
158+
# If the payload being used is for example cmd/unix/generic and not a payload spawning any kind of handler (bind or reverse)
159+
# we can query the /ztp/cgi-bin/dumpztplog.py for the stdout of the command and print it for the user.
161160
if payload_instance.connection_type == 'none'
162161
cmd_output_res = send_request_cgi({
163162
'method' => 'GET',

0 commit comments

Comments
 (0)