Skip to content

Commit 2e55dc4

Browse files
committed
fix: review suggestions
1 parent 2192184 commit 2e55dc4

File tree

3 files changed

+17
-13
lines changed

3 files changed

+17
-13
lines changed

src/services/anthropicService.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ export function getModels(): ModelsResponse {
1414
display_name: mockModel.name
1515
}));
1616

17-
return {
18-
data: models,
19-
first_id: models[0].id,
20-
last_id: models[models.length - 1].id,
21-
has_more: false
22-
}
17+
return {
18+
data: models,
19+
first_id: models.length > 0 ? models[0].id : null,
20+
last_id: models.length > 0 ? models[models.length - 1].id : null,
21+
has_more: false
22+
}
2323
}
2424
/**
2525
* Non-streaming response
@@ -85,7 +85,7 @@ export function createMessage(request: MessagesRequest): MessagesResponse | Erro
8585
/**
8686
* Streaming response
8787
*/
88-
export function* createMessageStream(request: MessagesRequest): any {
88+
export function* createMessageStream(request: MessagesRequest): Generator<string, void, unknown> {
8989
//validate model
9090
const model = findModelById(request.model);
9191
if(!model){

src/types/anthropic.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface Message {
1919
content: any; //temp
2020
}
2121

22-
export interface MCP_Server{
22+
export interface MCPServer{
2323
name: string
2424
type: 'url';
2525
url: string;
@@ -30,7 +30,7 @@ export interface MCP_Server{
3030
};
3131
}
3232

33-
export interface systemPrompt{
33+
export interface SystemPrompt{
3434
text: string;
3535
type: 'text';
3636
cache_control?: {
@@ -57,14 +57,14 @@ export interface MessagesRequest {
5757
messages: Message[];
5858
max_tokens: number;
5959
container?: string | null;
60-
mcp_server?: MCP_Server;
60+
mcp_server?: MCPServer;
6161
metadata?: {
6262
user_id?: string;
6363
};
6464
service_tier?: 'standard_only' | 'auto';
6565
stop_sequence?: string[];
6666
stream?: boolean;
67-
system?: systemPrompt;
67+
system?: SystemPrompt;
6868
temperature?: number;
6969
thinking?: Thinking;
7070
tool_choice?: any;
@@ -85,7 +85,7 @@ export interface Usage{
8585
server_tool_use: {
8686
web_search_requests: number;
8787
} | null;
88-
service_tire: 'standard' | 'priority' | 'batch' | null;
88+
service_tier: 'standard' | 'priority' | 'batch' | null;
8989
}
9090

9191
export interface Container{
@@ -156,6 +156,10 @@ export interface ContentBlockDeltaEvent{
156156
}
157157
}
158158

159+
export interface ContentBlockStopEvent { type: 'content_block_stop'; index: number; }
160+
export interface PingEvent { type: 'ping'; }
161+
export interface ErrorEvent { type: 'error'; error: string; }
162+
159163

160164
export type StreamingEvent =
161165
'message_start' |

src/utils/anthropicHelpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export function getCurrentTimestamp(): number {
1313
* Generate message ID
1414
*/
1515
export function generateMessageId(): string {
16-
return `msg_${Math.random().toString(36).substr(2, 9)}`;
16+
return `msg_${Math.random().toString(36).substring(2, 11)}`;
1717
}
1818

1919
/**

0 commit comments

Comments
 (0)