Skip to content

Commit cc187ff

Browse files
committed
fix: rename sess.CacheAll method to sess.Cache
1 parent 65e1767 commit cc187ff

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

session.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,11 @@ func (s *Session) deleteCache(key ...string) {
152152
}
153153
}
154154

155-
// CacheAll loads session values into memory for quick access.
155+
// Cache loads session values into memory for quick access.
156156
// Ideal for centralized session fetching, e.g., in middleware.
157157
// Subsequent Get/GetMulti calls return cached values, avoiding store access.
158158
// Use ResetCache() to ensure GetAll/Get/GetMulti fetches from the store.
159-
func (s *Session) CacheAll() error {
159+
func (s *Session) Cache() error {
160160
all, err := s.manager.store.GetAll(s.id)
161161
if err != nil {
162162
return err

session_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -239,13 +239,13 @@ func TestCacheAll(t *testing.T) {
239239

240240
// Test error.
241241
str.err = errors.New("store error")
242-
err = sess.CacheAll()
242+
err = sess.Cache()
243243
assert.ErrorIs(t, str.err, err)
244244
assert.Nil(t, sess.cache)
245245

246246
// Test without error.
247247
str.err = nil
248-
err = sess.CacheAll()
248+
err = sess.Cache()
249249
assert.NoError(t, err)
250250
assert.Equal(t, str.data, sess.cache)
251251
}
@@ -258,7 +258,7 @@ func TestResetCache(t *testing.T) {
258258
}
259259
mgr := newMockManager(str)
260260
sess, _ := mgr.NewSession(nil, nil)
261-
sess.CacheAll()
261+
sess.Cache()
262262
assert.Equal(t, str.data, sess.cache)
263263

264264
sess.ResetCache()
@@ -367,7 +367,7 @@ func TestSet(t *testing.T) {
367367
assert.Nil(t, sess.cache)
368368

369369
// Cache and set.
370-
err = sess.CacheAll()
370+
err = sess.Cache()
371371
assert.NoError(t, err)
372372
err = sess.Set("key1", 1)
373373
assert.NoError(t, err)
@@ -401,7 +401,7 @@ func TestSetMulti(t *testing.T) {
401401

402402
// Cache and set.
403403
str.data = map[string]interface{}{}
404-
err = sess.CacheAll()
404+
err = sess.Cache()
405405
assert.NoError(t, err)
406406
err = sess.SetMulti(data)
407407
assert.NoError(t, err)
@@ -432,7 +432,7 @@ func TestDelete(t *testing.T) {
432432
assert.NotContains(t, str.data, "key1")
433433

434434
// Cache and set.
435-
err = sess.CacheAll()
435+
err = sess.Cache()
436436
assert.NoError(t, err)
437437
err = sess.Delete("key2")
438438
assert.NoError(t, err)
@@ -478,7 +478,7 @@ func TestClear(t *testing.T) {
478478
mgr = newMockManager(str)
479479
sess, err = mgr.NewSession(nil, nil)
480480
assert.NoError(t, err)
481-
err = sess.CacheAll()
481+
err = sess.Cache()
482482
assert.NoError(t, err)
483483
assert.NotNil(t, sess.cache)
484484
err = sess.Clear()
@@ -529,7 +529,7 @@ func TestDestroy(t *testing.T) {
529529
"key2": 2,
530530
}
531531
assert.NoError(t, err)
532-
err = sess.CacheAll()
532+
err = sess.Cache()
533533
assert.NoError(t, err)
534534
assert.NotNil(t, sess.cache)
535535
err = sess.Clear()

0 commit comments

Comments
 (0)