Problem: bad code style in operator==

sigiesec · sigiesec · commit 2aac1dffa35d · 2018-04-13T11:38:16.000-04:00
Solution: simplified code
diff --git a/zmq.hpp b/zmq.hpp
@@ -393,10 +393,8 @@ namespace zmq
 
         inline bool operator==(const message_t &other) const ZMQ_NOTHROW
         {
-            size_t my_size = size ();
-            if (size () != other.size ())
-                return false;
-            return 0 == memcmp (data (), other.data (), my_size);
+            const size_t my_size = size ();
+            return my_size == other.size () && 0 == memcmp (data (), other.data (), my_size);
         }
 
         inline bool operator!=(const message_t &other) const ZMQ_NOTHROW

Original file line number	Diff line number	Diff line change
`@@ -393,10 +393,8 @@ namespace zmq`
`393`	`393`
`394`	`394`	`inline bool operator==(const message_t &other) const ZMQ_NOTHROW`
`395`	`395`	`{`
`396`		`- size_t my_size = size ();`
`397`		`- if (size () != other.size ())`
`398`		`- return false;`
`399`		`- return 0 == memcmp (data (), other.data (), my_size);`
	`396`	`+ const size_t my_size = size ();`
	`397`	`+ return my_size == other.size () && 0 == memcmp (data (), other.data (), my_size);`
`400`	`398`	`}`
`401`	`399`
`402`	`400`	`inline bool operator!=(const message_t &other) const ZMQ_NOTHROW`