Problem: code duplication in equals/operator==

sigiesec · sigiesec · commit 4367bd612811 · 2018-04-13T11:21:05.000-04:00
Solution: implemented equals using operator==
diff --git a/zmq.hpp b/zmq.hpp
@@ -388,11 +388,7 @@ namespace zmq
         ZMQ_DEPRECATED("from 4.3.0, use operator== instead")
         inline bool equal(const message_t* other) const ZMQ_NOTHROW
         {
-            if (size() != other->size())
-                return false;
-            const std::string a(data<char>(), size());
-            const std::string b(other->data<char>(), other->size());
-            return a == b;
+            return *this == *other;
         }
 
         inline bool operator==(const message_t &other) const ZMQ_NOTHROW

Original file line number	Diff line number	Diff line change
`@@ -388,11 +388,7 @@ namespace zmq`
`388`	`388`	`ZMQ_DEPRECATED("from 4.3.0, use operator== instead")`
`389`	`389`	`inline bool equal(const message_t* other) const ZMQ_NOTHROW`
`390`	`390`	`{`
`391`		`- if (size() != other->size())`
`392`		`- return false;`
`393`		`- const std::string a(data<char>(), size());`
`394`		`- const std::string b(other->data<char>(), other->size());`
`395`		`- return a == b;`
	`391`	`+ return this == other;`
`396`	`392`	`}`
`397`	`393`
`398`	`394`	`inline bool operator==(const message_t &other) const ZMQ_NOTHROW`