Skip to content

Commit 27c1f7c

Browse files
committed
Review feedback
1 parent 3e8ae8f commit 27c1f7c

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/NetMQ/Core/Patterns/Server.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ public Server(Ctx parent, int threadId, int socketId)
6767
/// <param name="icanhasall">not used</param>
6868
protected override void XAttachPipe(Pipe pipe, bool icanhasall)
6969
{
70-
Assumes.NotNull(pipe);
71-
7270
uint routingId = m_nextRoutingId++;
7371
if (routingId == 0)
7472
routingId = m_nextRoutingId++; // Never use Routing ID zero

src/NetMQ/Core/YPipe.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public bool CheckRead()
178178
/// Attempts to read an item from the pipe.
179179
/// </summary>
180180
/// <returns><c>true</c> if the read succeeded, otherwise <c>false</c>.</returns>
181-
public bool TryRead([MaybeNull] out T value)
181+
public bool TryRead([MaybeNullWhen(returnValue: false)] out T value)
182182
{
183183
// Try to prefetch a value.
184184
if (!CheckRead())

0 commit comments

Comments
 (0)