not all tests pass with cffi on cpython

memoryview(Frame) doesn't work with CFFI

Author: minrk

tests/test_message.py

@@ -16,7 +16,7 @@
 import time
 
 import zmq
-from zmq_test_utils import PYPY, BaseZMQTestCase, SkipTest, skip_pypy
+from zmq_test_utils import PYPY, BaseZMQTestCase, SkipTest, skip_cpython_cffi, skip_pypy
 
 # some useful constants:
 
@@ -230,6 +230,7 @@ def test_buffer_out(self):
         assert outb is m.buffer
         assert m.buffer is m.buffer
 
+    @skip_cpython_cffi
     def test_memoryview_shape(self):
         """memoryview shape info"""
         data = "§§¶•ªº˜µ¬˚…∆˙åß∂©œ∑´†≈ç√".encode()
@@ -278,6 +279,7 @@ def test_memoryview(self):
         assert s2 == s
         assert m.bytes == s
 
+    @skip_cpython_cffi
     def test_noncopying_recv(self):
         """check for clobbering message buffers"""
         null = b'\0' * 64
@@ -300,6 +302,7 @@ def test_noncopying_recv(self):
                 assert m2.bytes == ff
                 assert type(m2.bytes) is bytes
 
+    @skip_cpython_cffi
     def test_noncopying_memoryview(self):
         """test non-copying memmoryview messages"""
         null = b'\0' * 64

tests/test_socket.py

@@ -630,7 +630,7 @@ def test_large_send(self):
         # sample the front and back of the received message
         # without checking the whole content
         byte = ord(c)
-        view = memoryview(rcvd)
+        view = memoryview(rcvd.buffer)
         assert len(view) == N
         assert view[0] == byte
         assert view[-1] == byte

tests/zmq_test_utils.py

@@ -27,7 +27,8 @@
     have_gevent = False
 
 
-PYPY = platform.python_implementation() == 'PyPy'
+CFFI = zmq.backend.Socket.__module__.startswith("zmq.backend.cffi.")
+PYPY = platform.python_implementation() == 'PyPy' or CFFI
 
 # -----------------------------------------------------------------------------
 # skip decorators (directly from unittest)
@@ -38,7 +39,11 @@ def _id(x):
     return x
 
 
-skip_pypy = mark.skipif(PYPY, reason="Doesn't work on PyPy")
+skip_pypy = mark.skipif(PYPY, reason="Doesn't work on CFFI backend")
+skip_cpython_cffi = mark.skipif(
+    platform.python_implementation() == 'CPython' and CFFI,
+    reason="CFFI on CPython is unsupported",
+)
 require_zmq_4 = mark.skipif(zmq.zmq_version_info() < (4,), reason="requires zmq >= 4")
 
 # -----------------------------------------------------------------------------

zmq/sugar/frame.py

@@ -74,7 +74,7 @@ def __repr__(self):
         nbytes = len(self)
         msg_suffix = ""
         if nbytes > 16:
-            msg_bytes = bytes(memoryview(self)[:12])
+            msg_bytes = bytes(memoryview(self.buffer)[:12])
             if nbytes >= 1e9:
                 unit = "GB"
                 n = nbytes // 1e9