fix: fix the check for compat tests

aminya · aminya · commit 1489e6012ced · 2024-10-28T00:11:13.000-07:00
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -179,15 +179,15 @@ jobs:
             pnpm run test.unit
         continue-on-error: true
 
-      - name: Test Compatibility 
+      - name: Test Compatibility
         if: ${{ !matrix.docker }}
         uses: nick-fields/retry@v3
         with:
           timeout_minutes: 5
           max_attempts: 1
           command: |
             pnpm run clean.temp
-            pnpm run test.compat
+            pnpm run test.unit.compat
         continue-on-error: true
 
       - name: Test Electron (Main)
diff --git a/.mocharc.js b/.mocharc.js
@@ -3,7 +3,6 @@
  */
 const config = {
   require: ["ts-node/register"],
-  spec: ["test/unit/**/*-test.ts"],
   "expose-gc": true,
   "v8-expose-gc": true,
   exit: true,
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -18,6 +18,7 @@
   "mochaExplorer.env": {
     "INCLUDE_COMPAT_TESTS": "true"
   },
+  "mochaExplorer.files": "test/unit/**/*-test.ts",
   "files.exclude": {
     "**/.DS_Store": true,
     "**/Thumbs.db": true,
diff --git a/package.json b/package.json
@@ -98,11 +98,11 @@
     "build.native.debug": "cmake-ts dev-os-only",
     "build": "run-p build.js build.native",
     "build.debug": "run-s build.js build.native.debug",
-    "test": "run-s clean.temp test.unit.compat clean.temp test.unit",
-    "test.unit": "cross-env INCLUDE_COMPAT_TESTS=false mocha ./test/unit/*-test.ts",
-    "test.unit.compat": "cross-env INCLUDE_COMPAT_TESTS=true mocha ./test/unit/compat/*-test.ts",
+    "test": "run-s test.unit",
+    "test.unit": "run-s clean.temp build && cross-env INCLUDE_COMPAT_TESTS=false mocha ./test/unit/*-test.ts",
+    "test.unit.compat": "run-s clean.temp build && cross-env INCLUDE_COMPAT_TESTS=true mocha ./test/unit/compat/*-test.ts",
     "test.smoke": "bash ./script/smoke-test.bash",
-    "test.skip_gc_tests": "run-s clean.temp build.debug && cross-env SKIP_GC_TESTS=true mocha",
+    "test.skip_gc_tests": "run-s clean.temp build && cross-env SKIP_GC_TESTS=true mocha",
     "test.electron.main": "run-s clean.temp build && electron-mocha",
     "format": "run-s format.prettier format.clang-format",
     "format.prettier": "prettier -l --cache --cache-location ./.cache/prettier --write .",
diff --git a/test/unit/compat/context-test.ts b/test/unit/compat/context-test.ts
@@ -1,7 +1,7 @@
 import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   describe("compat context", function () {
     it("should support setting max io threads", function () {
       zmq.Context.setMaxThreads(3)
diff --git a/test/unit/compat/exports-test.ts b/test/unit/compat/exports-test.ts
@@ -3,7 +3,7 @@ import {capability} from "../../../src"
 import {assert} from "chai"
 import semver from "semver"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   describe("compat exports", function () {
     it("should export a valid version", function () {
       assert.ok(semver.valid(zmq.version))
diff --git a/test/unit/compat/gc-test.ts b/test/unit/compat/gc-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp", "inproc")) {
     describe(`compat socket with ${proto}`, function () {
       let address: string
diff --git a/test/unit/compat/socket-error-callback-test.ts b/test/unit/compat/socket-error-callback-test.ts
@@ -3,7 +3,7 @@ import type {Socket} from "../../../v5-compat"
 import {isFullError} from "../../../src/errors"
 import {assert} from "chai"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   describe("compat socket error callback", function () {
     let sock: Socket
 
diff --git a/test/unit/compat/socket-events-test.ts b/test/unit/compat/socket-events-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp", "inproc")) {
     describe(`compat socket with ${proto} events`, function () {
       let address: string
diff --git a/test/unit/compat/socket-messages-test.ts b/test/unit/compat/socket-messages-test.ts
@@ -2,8 +2,8 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
-  for (const proto of testProtos("tcp", "inproc")) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
+  for (const proto of testProtos( "inproc")) {
     describe(`compat socket with ${proto} messages`, function () {
       let push: zmq.Socket
       let pull: zmq.Socket
diff --git a/test/unit/compat/socket-monitor-test.ts b/test/unit/compat/socket-monitor-test.ts
@@ -4,7 +4,7 @@ import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 import {isFullError} from "../../../src/errors"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   /* This test case only seems to work reliably with TCP. */
   for (const proto of testProtos("tcp")) {
     describe(`compat socket with ${proto} monitor`, function () {
diff --git a/test/unit/compat/socket-pair-test.ts b/test/unit/compat/socket-pair-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp")) {
     describe(`compat socket with ${proto} pair`, function () {
       let address: string
diff --git a/test/unit/compat/socket-pub-sub-test.ts b/test/unit/compat/socket-pub-sub-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp", "inproc")) {
     describe(`compat socket with ${proto} pub-sub`, function () {
       let pub: zmq.Socket
diff --git a/test/unit/compat/socket-push-pull-test.ts b/test/unit/compat/socket-push-pull-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp", "inproc")) {
     describe(`compat socket with ${proto} push-pull`, function () {
       let address: string
diff --git a/test/unit/compat/socket-req-rep-test.ts b/test/unit/compat/socket-req-rep-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp", "inproc")) {
     describe(`compat socket with ${proto} req-rep`, function () {
       let address: string
diff --git a/test/unit/compat/socket-router-test.ts b/test/unit/compat/socket-router-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp", "inproc")) {
     describe(`compat socket with ${proto} router`, function () {
       let address: string
diff --git a/test/unit/compat/socket-stream-test.ts b/test/unit/compat/socket-stream-test.ts
@@ -3,7 +3,7 @@ import {assert} from "chai"
 import {uniqAddress} from "../helpers"
 import http from "http"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   describe("compat socket stream", function () {
     let address: string
     beforeEach(async () => {
diff --git a/test/unit/compat/socket-test.ts b/test/unit/compat/socket-test.ts
@@ -1,7 +1,7 @@
 import * as zmq from "../../../v5-compat"
 import { assert } from "chai"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   describe("compat socket", function () {
     let sock: zmq.Socket
 
diff --git a/test/unit/compat/socket-unbind-test.ts b/test/unit/compat/socket-unbind-test.ts
@@ -6,7 +6,7 @@ import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
 if (
-  process.env.INCLUDE_COMPAT_TESTS &&
+  process.env.INCLUDE_COMPAT_TESTS === "true" &&
   process.env.INCLUDE_COMPAT_UNBIND_TEST
 ) {
   for (const proto of testProtos("tcp")) {
diff --git a/test/unit/compat/socket-xpub-xsub-test.ts b/test/unit/compat/socket-xpub-xsub-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp", "inproc")) {
     let address1: string
     let address2: string
diff --git a/test/unit/compat/socket-zap-test.ts b/test/unit/compat/socket-zap-test.ts
@@ -4,7 +4,7 @@ import semver from "semver"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   function start() {
     const zap = zmq.socket("router")
 
diff --git a/test/unit/compat/zmq-proxy-push-pull-test.ts b/test/unit/compat/zmq-proxy-push-pull-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp")) {
     describe(`compat proxy with ${proto} push-pull`, function () {
       const sockets: zmq.Socket[] = []
diff --git a/test/unit/compat/zmq-proxy-router-dealer-test.ts b/test/unit/compat/zmq-proxy-router-dealer-test.ts
@@ -2,7 +2,7 @@ import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp")) {
     describe(`compat proxy with ${proto} router-dealer`, function () {
       const sockets: zmq.Socket[] = []
diff --git a/test/unit/compat/zmq-proxy-test.ts b/test/unit/compat/zmq-proxy-test.ts
@@ -1,7 +1,7 @@
 import * as zmq from "../../../v5-compat"
 import {assert} from "chai"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   describe("compat proxy", function () {
     it("should be a function off the module namespace", function () {
       assert.typeOf(zmq.proxy, "function")
diff --git a/test/unit/compat/zmq-proxy-xpub-xsub-test.ts b/test/unit/compat/zmq-proxy-xpub-xsub-test.ts
@@ -3,7 +3,7 @@ import {assert} from "chai"
 import {testProtos, uniqAddress} from "../helpers"
 import {isFullError} from "../../../src/errors"
 
-if (process.env.INCLUDE_COMPAT_TESTS) {
+if (process.env.INCLUDE_COMPAT_TESTS === "true") {
   for (const proto of testProtos("tcp")) {
     describe(`compat proxy with ${proto} xpub-xsub`, function () {
       const sockets: zmq.Socket[] = []
