test: improve the type of the weak refs

Author: aminya

.vscode/settings.json

@@ -1,4 +1,7 @@
 {
   "mochaExplorer.parallel": true,
-  "mochaExplorer.globImplementation": "vscode"
+  "mochaExplorer.globImplementation": "vscode",
+  "mochaExplorer.nodeArgv": [
+    "--expose-gc"
+  ]
 }

test/unit/helpers.ts

@@ -264,10 +264,10 @@ export function getGcOrSkipTest(test: Mocha.Context) {
     test.skip()
   }
 
-  const gc = globalThis.gc as undefined | GCFunction
+  const gc = global.gc as undefined | GCFunction
   if (typeof gc !== "function") {
     throw new Error(
-      "Garbage collection is not exposed. It may be enabled by the node --expose-gc flag. To skip GC tests, set the environment variable `SKIP_GC_TESTS`",
+      "Garbage collection is not exposed. It may be enabled by the node --expose-gc flag or v8-expose-gc flag in Mocha. To skip GC tests, set the environment variable `SKIP_GC_TESTS`",
     )
   }
   // https://github.com/nodejs/node/blob/v20.0.0/deps/v8/src/extensions/gc-extension.h

test/unit/socket-close-test.ts

@@ -100,6 +100,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
           await promise
           assert.ok(false)
         } catch (err) {
+          console.log(err)
           /* Ignore */
         }
         assert.equal(sock.closed, true)
@@ -109,7 +110,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
         const gc = getGcOrSkipTest(this)
         this.slow(200)
 
-        let weakRef: undefined | WeakRef<any>
+        let weakRef: undefined | WeakRef<zmq.Context>
 
         const task = async () => {
           const context: zmq.Context | undefined = new zmq.Context()
@@ -125,7 +126,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
         await gc()
 
         assert.isDefined(weakRef)
-        assert.isUndefined(weakRef!.deref())
+        assert.isUndefined(weakRef.deref())
       })
     })
 
@@ -137,7 +138,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
         }
         this.slow(200)
 
-        let weakRef: undefined | WeakRef<any>
+        let weakRef: undefined | WeakRef<zmq.Context>
         const task = async () => {
           const context: zmq.Context | undefined = new zmq.Context()
           const _dealer = new zmq.Dealer({context, linger: 0})
@@ -148,7 +149,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
         await gc()
 
         assert.isDefined(weakRef)
-        assert.isUndefined(weakRef!.deref())
+        assert.isUndefined(weakRef.deref())
       })
     })
   })

test/unit/socket-send-receive-test.ts

@@ -91,7 +91,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
 
       it("should copy and release small buffers", async function () {
         const gc = getGcOrSkipTest(this)
-        let weakRef: undefined | WeakRef<any>
+        let weakRef: undefined | WeakRef<Buffer>
         sockA.connect(await uniqAddress(proto))
         const send = async (size: number) => {
           const msg = Buffer.alloc(size)
@@ -107,7 +107,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
 
       it("should retain large buffers", async function () {
         const gc = getGcOrSkipTest(this)
-        let weakRef: undefined | WeakRef<any>
+        let weakRef: undefined | WeakRef<Buffer>
 
         sockA.connect(await uniqAddress(proto))
         const send = async (size: number) => {
@@ -232,6 +232,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
       it("should deliver messages coercible to string", async function () {
         const messages = [
           null,
+          // eslint-disable-next-line no-empty-function
           function () {},
           16.19,
           true,