fix: use explicit conversions for msg pointers

Author: aminya

src/incoming_msg.cc

@@ -27,8 +27,8 @@ Napi::Value IncomingMsg::IntoBuffer(const Napi::Env& env) {
             return env.Undefined();
         }
     }
-    auto* data = reinterpret_cast<uint8_t*>(zmq_msg_data(*ref));
-    auto length = zmq_msg_size(*ref);
+    auto* data = reinterpret_cast<uint8_t*>(zmq_msg_data(ref->get()));
+    auto length = zmq_msg_size(ref->get());
 
     if (noElectronMemoryCage) {
         static auto constexpr zero_copy_threshold = 1U << 7U;
@@ -43,7 +43,7 @@ Napi::Value IncomingMsg::IntoBuffer(const Napi::Env& env) {
                 env, static_cast<int64_t>(length));
 
             auto release = [](const Napi::Env& env, uint8_t*, Reference* ref) {
-                const auto length = static_cast<int64_t>(zmq_msg_size(*ref));
+                const auto length = static_cast<int64_t>(zmq_msg_size(ref->get()));
                 Napi::MemoryManagement::AdjustExternalMemory(env, -length);
                 delete ref;
             };

src/incoming_msg.h

@@ -15,9 +15,8 @@ class IncomingMsg {
 
     Napi::Value IntoBuffer(const Napi::Env& env);
 
-    // NOLINTNEXTLINE(*-explicit-*)
-    inline operator zmq_msg_t*() {
-        return *ref;
+    zmq_msg_t* get() {
+        return ref->get();
     }
 
 private:
@@ -28,8 +27,7 @@ class IncomingMsg {
         Reference();
         ~Reference();
 
-        // NOLINTNEXTLINE(*-explicit-*)
-        inline operator zmq_msg_t*() {
+        zmq_msg_t* get() {
             return &msg;
         }
     };

src/outgoing_msg.h

@@ -24,8 +24,7 @@ class OutgoingMsg {
     explicit OutgoingMsg(Napi::Value value, Module& module);
     ~OutgoingMsg();
 
-    // NOLINTNEXTLINE(*-explicit-*)
-    inline operator zmq_msg_t*() {
+    zmq_msg_t* get() {
         return &msg;
     }
 

src/socket.cc

@@ -295,7 +295,7 @@ void Socket::Send(const Napi::Promise::Deferred& res, OutgoingMsg::Parts& parts)
         iter++;
 
         auto const flags = iter == end ? ZMQ_DONTWAIT : ZMQ_DONTWAIT | ZMQ_SNDMORE;
-        while (zmq_msg_send(part, socket, flags) < 0) {
+        while (zmq_msg_send(part.get(), socket, flags) < 0) {
             if (zmq_errno() != EINTR) {
                 res.Reject(ErrnoException(Env(), zmq_errno()).Value());
                 return;
@@ -314,7 +314,7 @@ void Socket::Receive(const Napi::Promise::Deferred& res) {
     uint32_t i = 0;
     while (true) {
         IncomingMsg part;
-        while (zmq_msg_recv(part, socket, ZMQ_DONTWAIT) < 0) {
+        while (zmq_msg_recv(part.get(), socket, ZMQ_DONTWAIT) < 0) {
             if (zmq_errno() != EINTR) {
                 res.Reject(ErrnoException(Env(), zmq_errno()).Value());
                 return;
@@ -343,7 +343,7 @@ void Socket::Receive(const Napi::Promise::Deferred& res) {
         }
 #endif
 
-        if (zmq_msg_more(part) == 0) {
+        if (zmq_msg_more(part.get()) == 0) {
             break;
         }
     }