fix: fix rest of sign conversions for timeout/error

Author: aminya

src/incoming_msg.cc

@@ -39,7 +39,8 @@ Napi::Value IncomingMsg::IntoBuffer(const Napi::Env& env) {
             moved = true;
 
             /* Put appropriate GC pressure according to the size of the buffer. */
-            Napi::MemoryManagement::AdjustExternalMemory(env, length);
+            Napi::MemoryManagement::AdjustExternalMemory(
+                env, static_cast<int64_t>(length));
 
             auto release = [](const Napi::Env& env, uint8_t*, Reference* ref) {
                 const auto length = static_cast<int64_t>(zmq_msg_size(*ref));

src/observer.cc

@@ -1,6 +1,8 @@
 
 #include "./observer.h"
 
+#include <cstdint>
+
 #include "./context.h"
 #include "./module.h"
 #include "./socket.h"
@@ -283,7 +285,7 @@ void Observer::Receive(const Napi::Promise::Deferred& res) {
 #ifdef ZMQ_EVENT_HANDSHAKE_FAILED_NO_DETAIL
     case ZMQ_EVENT_HANDSHAKE_FAILED_NO_DETAIL:
 #endif
-        event["error"] = ErrnoException(Env(), value).Value();
+        event["error"] = ErrnoException(Env(), static_cast<int32_t>(value)).Value();
         break;
 
 #ifdef ZMQ_EVENT_HANDSHAKE_FAILED_PROTOCOL
@@ -305,6 +307,8 @@ void Observer::Receive(const Napi::Promise::Deferred& res) {
         Close();
         break;
     }
+    default:
+        break;
     }
 
     res.Resolve(event);

src/socket.cc

@@ -872,10 +872,12 @@ void Socket::SetSockOpt(const Napi::CallbackInfo& info) {
     /* Mirror a few options that are used internally. */
     switch (option) {
     case ZMQ_SNDTIMEO:
-        send_timeout = value;
+        send_timeout = static_cast<int64_t>(value);
         break;
     case ZMQ_RCVTIMEO:
-        receive_timeout = value;
+        receive_timeout = static_cast<int64_t>(value);
+        break;
+    default:
         break;
     }
 }

src/util/uvdelayed.h

@@ -29,7 +29,7 @@ class UvDelayed {
         [[maybe_unused]] int32_t err = 0;
 
         /* Idle handle is needed to stop the event loop from blocking in poll. */
-        err = uv_idle_start(idle, [](uv_idle_t* idle) {});
+        err = uv_idle_start(idle, []([[maybe_unused]] uv_idle_t* idle) {});
         assert(err == 0);
 
         err = uv_check_start(check, [](uv_check_t* check) {