Merge pull request #1176 from jimklimov/shadow-travis

Problem : outdated coding patterns come as a surprise with new compilers

Author: bluca

README.md

@@ -206,6 +206,8 @@ zproject's `project.xml` contains an extensive description of the available conf
             <option name="clangformat_implem" value="cmake|autotools" /> will pick one of two implems of the clang-format test in Travis CI (cmake is default and faster if available, since autotools needs to configure first)
             <option name="check_abi_compliance" value="0" /> "1" will compare the currently tested commit's ABI to the one in a "latest_release" branch or tag, using packaged prerequisites. Due to these limitations, the option is off by default.
             <option name="check_zproject" value="0" /> "1" will regenerate the zproject of the tested commit, and will verify that nothing changed, "2" will enable it as a special testcase allowed to fail. Many projects do customize their originally generated codebase, so to avoid surprises this option is off by default.
+            <option name="shadow_gcc" value="0" /> "1" will enable builds with warnings configured as fatal in additional recent versions of GCC, and "2" will make failures in these cases non-fatal so you can take time to modernize your code with modern best practices in mind. This is off "0" by default.
+            <option name="shadow_clang" value="0" /> "1" will enable builds with warnings configured as fatal in additional recent versions of CLANG, and "2" will make failures in these cases non-fatal so you can take time to modernize your code with modern best practices in mind. This is off "0" by default.
         vs2008              Microsoft Visual Studio 2008
         vs2010              Microsoft Visual Studio 2010
         vs2012              Microsoft Visual Studio 2012

project.xml

@@ -29,6 +29,8 @@
             <option name="clangformat_implem" value="cmake|autotools" /> will pick one of two implems of the clang-format test in Travis CI (cmake is default and faster if available, since autotools needs to configure first)
             <option name="check_abi_compliance" value="0" /> "1" will compare the currently tested commit's ABI to the one in a "latest_release" branch or tag, using packaged prerequisites. Due to these limitations, the option is off by default.
             <option name="check_zproject" value="0" /> "1" will regenerate the zproject of the tested commit, and will verify that nothing changed, "2" will enable it as a special testcase allowed to fail. Many projects do customize their originally generated codebase, so to avoid surprises this option is off by default.
+            <option name="shadow_gcc" value="0" /> "1" will enable builds with warnings configured as fatal in additional recent versions of GCC, and "2" will make failures in these cases non-fatal so you can take time to modernize your code with modern best practices in mind. This is off "0" by default.
+            <option name="shadow_clang" value="0" /> "1" will enable builds with warnings configured as fatal in additional recent versions of CLANG, and "2" will make failures in these cases non-fatal so you can take time to modernize your code with modern best practices in mind. This is off "0" by default.
         vs2008              Microsoft Visual Studio 2008
         vs2010              Microsoft Visual Studio 2010
         vs2012              Microsoft Visual Studio 2012

zproject_travis.gsl

@@ -227,6 +227,137 @@ matrix:
         - *pkg_deps_devtools
         - *pkg_deps_zproject
 .endif
+.if (defined (project.travis_shadow_clang) & !(project.travis_shadow_clang ?= 0)) | (defined (project.travis_shadow_gcc) & !(project.travis_shadow_gcc ?= 0))
+# Shadow-compilation setups below inspired by https://docs.travis-ci.com/user/languages/cpp/
+.endif
+.if defined (project.travis_shadow_clang) & !(project.travis_shadow_clang ?= 0)
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=clang-5.0 && CXX=clang++-5.0"
+    os: linux
+.if (project.travis_dist ?<> "")
+    dist: $(project.travis_dist)
+.endif
+    addons:
+      apt:
+        sources:
+        - llvm-toolchain-trusty-5.0
+.if (pkg_src_zeromq_dist ?<> "")
+        - *$(pkg_src_zeromq_dist)
+.endif
+        packages:
+        - *pkg_deps_common
+        - clang-5.0
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=clang-4.0 && CXX=clang++-4.0"
+    os: linux
+.if (project.travis_dist ?<> "")
+    dist: $(project.travis_dist)
+.endif
+    addons:
+      apt:
+        sources:
+        - llvm-toolchain-trusty-4.0
+.if (pkg_src_zeromq_dist ?<> "")
+        - *$(pkg_src_zeromq_dist)
+.endif
+        packages:
+        - *pkg_deps_common
+        - clang-4.0
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=clang-3.9 && CXX=clang++-3.9"
+    os: linux
+.if (project.travis_dist ?<> "")
+    dist: $(project.travis_dist)
+.endif
+    addons:
+      apt:
+        sources:
+        - llvm-toolchain-trusty-3.9
+.if (pkg_src_zeromq_dist ?<> "")
+        - *$(pkg_src_zeromq_dist)
+.endif
+        packages:
+        - *pkg_deps_common
+        - clang-3.9
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=clang-3.8 && CXX=clang++-3.8"
+    os: linux
+.if (project.travis_dist ?<> "")
+    dist: $(project.travis_dist)
+.endif
+    addons:
+      apt:
+        sources:
+        - llvm-toolchain-trusty-3.8
+.if (pkg_src_zeromq_dist ?<> "")
+        - *$(pkg_src_zeromq_dist)
+.endif
+        packages:
+        - *pkg_deps_common
+        - clang-3.8
+.endif
+.if defined (project.travis_shadow_gcc) & !(project.travis_shadow_gcc ?= 0)
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=gcc-4.9 && CXX=g++-4.9"
+    os: linux
+.if (project.travis_dist ?<> "")
+    dist: $(project.travis_dist)
+.endif
+    addons:
+      apt:
+        sources:
+        - ubuntu-toolchain-r-test
+.if (pkg_src_zeromq_dist ?<> "")
+        - *$(pkg_src_zeromq_dist)
+.endif
+        packages:
+        - *pkg_deps_common
+        - g++-4.9
+        - gcc-4.9
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=gcc-5 && CXX=g++-5"
+    os: linux
+.if (project.travis_dist ?<> "")
+    dist: $(project.travis_dist)
+.endif
+    addons:
+      apt:
+        sources:
+        - ubuntu-toolchain-r-test
+.if (pkg_src_zeromq_dist ?<> "")
+        - *$(pkg_src_zeromq_dist)
+.endif
+        packages:
+        - *pkg_deps_common
+        - g++-5
+        - gcc-5
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=gcc-6 && CXX=g++-6"
+    os: linux
+.if (project.travis_dist ?<> "")
+    dist: $(project.travis_dist)
+.endif
+    addons:
+      apt:
+        sources:
+        - ubuntu-toolchain-r-test
+.if (pkg_src_zeromq_dist ?<> "")
+        - *$(pkg_src_zeromq_dist)
+.endif
+        packages:
+        - *pkg_deps_common
+        - g++-6
+        - gcc-6
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=gcc-7 && CXX=g++-7"
+    os: linux
+.if (project.travis_dist ?<> "")
+    dist: $(project.travis_dist)
+.endif
+    addons:
+      apt:
+        sources:
+        - ubuntu-toolchain-r-test
+.if (pkg_src_zeromq_dist ?<> "")
+        - *$(pkg_src_zeromq_dist)
+.endif
+        packages:
+        - *pkg_deps_common
+        - g++-7
+        - gcc-7
+.endif
 .if project.travis_clangformat_implem ?= "autotools" | ( !defined(project.travis_clangformat_implem) & project.travis_use_cmake ?= 0 )
 .   echo "TRAVIS: CLANG-FORMAT: implementation: autotools"
 ### Note: we don't use CMake
@@ -255,7 +386,7 @@ matrix:
 #autotools#\
 .endif
         - *pkg_deps_prereqs
-.if project.travis_clangformat_allow_failures ?= 1 | project.travis_distcheck ?= 2
+.if project.travis_clangformat_allow_failures ?= 1 | project.travis_distcheck ?= 2 | project.travis_shadow_gcc ?=2 | project.travis_shadow_clang ?= 2
 # Note: "env" lines below must exactly describe a matrix option defined above
   allow_failures:
 .   if project.travis_distcheck ?= 2
@@ -266,6 +397,20 @@ matrix:
 .   echo "TRAVIS: CHECK_ZPROJECT: allow-fail: true"
   - env: BUILD_TYPE=check_zproject
 .   endif
+.   if project.travis_shadow_gcc ?= 2
+.   echo "TRAVIS: Shadow GCC versions: allow-fail: true"
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=gcc-4.9 && CXX=g++-4.9"
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=gcc-5 && CXX=g++-5"
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=gcc-6 && CXX=g++-6"
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=gcc-7 && CXX=g++-7"
+.   endif
+.   if project.travis_shadow_clang ?= 2
+.   echo "TRAVIS: Shadow CLANG versions: allow-fail: true"
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=clang-5.0 && CXX=clang++-5.0"
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=clang-4.0 && CXX=clang++-4.0"
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=clang-3.9 && CXX=clang++-3.9"
+  - env: BUILD_TYPE=default-Werror MATRIX_EVAL="CC=clang-3.8 && CXX=clang++-3.8"
+.   endif
 .   if project.travis_clangformat_allow_failures ?= 1
 .   echo "TRAVIS: CLANG-FORMAT: allow-fail: true"
 .       if project.travis_clangformat_implem ?= "autotools" | ( !defined(project.travis_clangformat_implem) & project.travis_use_cmake ?= 0 )
@@ -303,6 +448,7 @@ matrix:
 before_install:
 - if [ "$TRAVIS_OS_NAME" == "osx" -a "$BUILD_TYPE" == "android" ] ; then brew install binutils ; fi
 - if [ "$TRAVIS_OS_NAME" == "osx" -a "$BUILD_TYPE" == "valgrind" ] ; then brew install valgrind ; fi
+- if [ -n "\${MATRIX_EVAL}" ] ; then eval \${MATRIX_EVAL} ; fi
 
 # Hand off to generated script for each BUILD_TYPE
 script: ./ci_build.sh