don't fail immediately on transient error in get process detail loop

tikinang · tikinang · commit 92fb330005a6 · 2026-03-17T10:49:27.000+01:00
diff --git a/src/cmd/projectDelete.go b/src/cmd/projectDelete.go
@@ -76,7 +76,7 @@ func projectDeleteCmd() *cmdBuilder.Cmd {
 				ctx,
 				cmdData.UxBlocks,
 				[]uxHelpers.Process{{
-					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient),
+					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient, cmdData.UxBlocks),
 					RunningMessage:      i18n.T(i18n.ProjectDeleting),
 					ErrorMessageMessage: i18n.T(i18n.ProjectDeleteFailed),
 					SuccessMessage:      i18n.T(i18n.ProjectDeleted),
diff --git a/src/cmd/projectImport.go b/src/cmd/projectImport.go
@@ -71,7 +71,7 @@ func projectImportCmd() *cmdBuilder.Cmd {
 			for _, service := range responseOutput.ServiceStacks {
 				for _, process := range service.Processes {
 					processes = append(processes, uxHelpers.Process{
-						F:                   uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient),
+						F:                   uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient, cmdData.UxBlocks),
 						RunningMessage:      service.Name.String() + ": " + process.ActionName.String(),
 						ErrorMessageMessage: service.Name.String() + ": " + process.ActionName.String(),
 						SuccessMessage:      service.Name.String() + ": " + process.ActionName.String(),
diff --git a/src/cmd/projectServiceImport.go b/src/cmd/projectServiceImport.go
@@ -66,7 +66,7 @@ func projectServiceImportCmd() *cmdBuilder.Cmd {
 			for _, service := range responseOutput.ServiceStacks {
 				for _, process := range service.Processes {
 					processes = append(processes, uxHelpers.Process{
-						F:                   uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient),
+						F:                   uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient, cmdData.UxBlocks),
 						RunningMessage:      service.Name.String() + ": " + process.ActionName.String(),
 						ErrorMessageMessage: service.Name.String() + ": " + process.ActionName.String(),
 						SuccessMessage:      service.Name.String() + ": " + process.ActionName.String(),
diff --git a/src/cmd/serviceCreate.go b/src/cmd/serviceCreate.go
@@ -188,7 +188,7 @@ func serviceCreateCmd() *cmdBuilder.Cmd {
 				cmdData.UxBlocks,
 				[]uxHelpers.Process{
 					{
-						F:                   uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient),
+						F:                   uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient, cmdData.UxBlocks),
 						RunningMessage:      "Creating service",
 						ErrorMessageMessage: "Service creation failed",
 						SuccessMessage:      "Service created",
diff --git a/src/cmd/serviceDelete.go b/src/cmd/serviceDelete.go
@@ -75,7 +75,7 @@ func serviceDeleteCmd() *cmdBuilder.Cmd {
 				ctx,
 				cmdData.UxBlocks,
 				[]uxHelpers.Process{{
-					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient),
+					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient, cmdData.UxBlocks),
 					RunningMessage:      i18n.T(i18n.ServiceDeleting),
 					ErrorMessageMessage: i18n.T(i18n.ServiceDeleteFailed),
 					SuccessMessage:      i18n.T(i18n.ServiceDeleted),
diff --git a/src/cmd/serviceDeploy.go b/src/cmd/serviceDeploy.go
@@ -201,7 +201,7 @@ func serviceDeployCmd() *cmdBuilder.Cmd {
 				ctx,
 				cmdData.UxBlocks,
 				[]uxHelpers.Process{{
-					F:                   uxHelpers.CheckZeropsProcess(deployProcess.Id, cmdData.RestApiClient),
+					F:                   uxHelpers.CheckZeropsProcess(deployProcess.Id, cmdData.RestApiClient, cmdData.UxBlocks),
 					RunningMessage:      i18n.T(i18n.DeployRunning),
 					ErrorMessageMessage: i18n.T(i18n.DeployFailed),
 					SuccessMessage:      i18n.T(i18n.DeployFinished),
diff --git a/src/cmd/serviceEnableSubdomain.go b/src/cmd/serviceEnableSubdomain.go
@@ -44,7 +44,7 @@ func serviceEnableSubdomainCmd() *cmdBuilder.Cmd {
 				ctx,
 				cmdData.UxBlocks,
 				[]uxHelpers.Process{{
-					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient),
+					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient, cmdData.UxBlocks),
 					RunningMessage:      i18n.T(i18n.ServiceEnablingSubdomain),
 					ErrorMessageMessage: i18n.T(i18n.ServiceEnableSubdomainFailed),
 					SuccessMessage:      i18n.T(i18n.ServiceEnabledSubdomain),
diff --git a/src/cmd/servicePush.go b/src/cmd/servicePush.go
@@ -213,7 +213,7 @@ func servicePushCmd() *cmdBuilder.Cmd {
 				cmdData.UxBlocks,
 				[]uxHelpers.Process{
 					{
-						F: uxHelpers.CheckZeropsProcess(deployProcess.Id, cmdData.RestApiClient,
+						F: uxHelpers.CheckZeropsProcess(deployProcess.Id, cmdData.RestApiClient, cmdData.UxBlocks,
 							uxHelpers.CheckZeropsProcessWithProcessOutputCallback(
 								func(ctx context.Context, process *uxHelpers.Process, apiProcess output.Process) error {
 									if cmdData.Params.GetBool("disable-logs") {
diff --git a/src/cmd/serviceStart.go b/src/cmd/serviceStart.go
@@ -43,7 +43,7 @@ func serviceStartCmd() *cmdBuilder.Cmd {
 				ctx,
 				cmdData.UxBlocks,
 				[]uxHelpers.Process{{
-					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient),
+					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient, cmdData.UxBlocks),
 					RunningMessage:      i18n.T(i18n.ServiceStarting),
 					ErrorMessageMessage: i18n.T(i18n.ServiceStartFailed),
 					SuccessMessage:      i18n.T(i18n.ServiceStarted),
diff --git a/src/cmd/serviceStop.go b/src/cmd/serviceStop.go
@@ -44,7 +44,7 @@ func serviceStopCmd() *cmdBuilder.Cmd {
 				ctx,
 				cmdData.UxBlocks,
 				[]uxHelpers.Process{{
-					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient),
+					F:                   uxHelpers.CheckZeropsProcess(processId, cmdData.RestApiClient, cmdData.UxBlocks),
 					RunningMessage:      i18n.T(i18n.ServiceStopping),
 					ErrorMessageMessage: i18n.T(i18n.ServiceStopFailed),
 					SuccessMessage:      i18n.T(i18n.ServiceStopped),
diff --git a/src/cmdBuilder/scopeService.go b/src/cmdBuilder/scopeService.go
@@ -210,7 +210,7 @@ func createNewService(ctx context.Context, project entity.Project, cmdData *Logg
 		cmdData.UxBlocks,
 		[]uxHelpers.Process{
 			{
-				F:                   uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient),
+				F:                   uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient, cmdData.UxBlocks),
 				RunningMessage:      "Creating service",
 				ErrorMessageMessage: "Service creation failed",
 				SuccessMessage:      "Service created",
diff --git a/src/uxHelpers/spinner.go b/src/uxHelpers/spinner.go
@@ -102,28 +102,49 @@ type checkZeropsProcessSetup struct {
 func CheckZeropsProcess(
 	processId uuid.ProcessId,
 	restApiClient *zeropsRestApiClient.Handler,
+	uxBlocks *uxBlock.Blocks,
 	options ...gn.Option[checkZeropsProcessSetup],
 ) ProcessFunc {
 	setup := gn.ApplyOptions(options...)
 	return func(ctx context.Context, process *Process) error {
 		ticker := time.NewTicker(time.Second)
 		defer ticker.Stop()
 
+		var firstErrTime time.Time
+		handleTransientErr := func(err error) error {
+			if firstErrTime.IsZero() {
+				firstErrTime = time.Now()
+			}
+			if time.Since(firstErrTime) >= time.Minute {
+				return err
+			}
+			uxBlocks.PrintWarningTextf("failed to get process detail: %v", err)
+			return nil
+		}
+
 		for {
 			select {
 			case <-ctx.Done():
 				return nil
 			case <-ticker.C:
 				getProcessResponse, err := restApiClient.GetProcess(ctx, path.ProcessId{Id: processId})
 				if err != nil {
-					return err
+					if err := handleTransientErr(err); err != nil {
+						return err
+					}
+					continue
 				}
 
 				processOutput, err := getProcessResponse.Output()
 				if err != nil {
-					return err
+					if err := handleTransientErr(err); err != nil {
+						return err
+					}
+					continue
 				}
 
+				firstErrTime = time.Time{}
+
 				if callback, exists := setup.processOutputCallback.Get(); exists {
 					if err := callback(ctx, process, processOutput); err != nil {
 						return err
@@ -133,20 +154,10 @@ func CheckZeropsProcess(
 				processStatus := processOutput.Status
 
 				switch processStatus {
-				case enum.ProcessStatusEnumPending:
-					continue
-				case enum.ProcessStatusEnumRunning:
+				case enum.ProcessStatusEnumPending, enum.ProcessStatusEnumRunning:
 					continue
 				case enum.ProcessStatusEnumFinished:
 					return nil
-				case enum.ProcessStatusEnumRollbacking:
-					fallthrough
-				case enum.ProcessStatusEnumCanceling:
-					fallthrough
-				case enum.ProcessStatusEnumFailed:
-					fallthrough
-				case enum.ProcessStatusEnumCanceled:
-					fallthrough
 				default:
 					return errors.Errorf(i18n.T(i18n.ProcessInvalidState), processId)
 				}

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ func serviceCreateCmd() *cmdBuilder.Cmd {`
`188`	`188`	`cmdData.UxBlocks,`
`189`	`189`	`[]uxHelpers.Process{`
`190`	`190`	`{`
`191`		`- F: uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient),`
	`191`	`+ F: uxHelpers.CheckZeropsProcess(process.Id, cmdData.RestApiClient, cmdData.UxBlocks),`
`192`	`192`	`RunningMessage: "Creating service",`
`193`	`193`	`ErrorMessageMessage: "Service creation failed",`
`194`	`194`	`SuccessMessage: "Service created",`
Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,7 @@ func servicePushCmd() *cmdBuilder.Cmd {`
`213`	`213`	`cmdData.UxBlocks,`
`214`	`214`	`[]uxHelpers.Process{`
`215`	`215`	`{`
`216`		`- F: uxHelpers.CheckZeropsProcess(deployProcess.Id, cmdData.RestApiClient,`
	`216`	`+ F: uxHelpers.CheckZeropsProcess(deployProcess.Id, cmdData.RestApiClient, cmdData.UxBlocks,`
`217`	`217`	`uxHelpers.CheckZeropsProcessWithProcessOutputCallback(`
`218`	`218`	`func(ctx context.Context, process *uxHelpers.Process, apiProcess output.Process) error {`
`219`	`219`	`if cmdData.Params.GetBool("disable-logs") {`