Skip to content

Commit 64214a7

Browse files
committed
bug: fixed radial function when it is not set
Signed-off-by: Nick Papior <[email protected]>
1 parent 40c23d1 commit 64214a7

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

sisl/orbital.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,9 @@ def set_radial(self, *args, **kwargs):
446446
"""
447447
if len(args) == 0:
448448
# Return immediately
449-
return
449+
def f0(R):
450+
return R * 0.
451+
self.set_radial(f0)
450452
elif len(args) == 1 and callable(args[0]):
451453
self.f = args[0]
452454
# Determine the maximum R

sisl/tests/test_orbital.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,14 @@ def test_set_radial1(self):
106106
o = SphericalOrbital(1, rf)
107107
o.set_radial(1.)
108108

109+
def test_set_radial_none(self):
110+
rf = r_f(6)
111+
o = SphericalOrbital(1, rf)
112+
o.set_radial()
113+
r = np.linspace(0, 6, 400)
114+
r0 = o.radial(r)
115+
assert np.allclose(r0, 0)
116+
109117
def test_radial1(self):
110118
rf = r_f(6)
111119
orb0 = SphericalOrbital(0, rf)

0 commit comments

Comments
 (0)