maint: fixed minor things in bandsXarray

Changed names for attributes (matches matplotlib)
Changed names for coordinates to match names used
throughout sisl. Also added use of sisl._array

Fixed a bug in PDOS for empty data.

Signed-off-by: Nick Papior <[email protected]>

Author: zerothi

sisl/io/siesta/bands.py

@@ -1,5 +1,6 @@
 import numpy as np
 
+import sisl._array as _a
 from sisl.utils import strmap
 from sisl.utils.cmd import default_ArgumentParser, default_namespace
 from ..sile import add_sile, sile_fh_open
@@ -21,7 +22,7 @@ def read_data(self, as_dataarray=False):
         as_dataarray: boolean, optional
             if `True`, the information is returned as an `xarray.DataArray`
             Ticks (if read) are stored as an attribute of the DataArray 
-            (under `array.tick_vals` and `array.tick_labels`)
+            (under `array.ticks` and `array.ticklabels`)
         """
         band_lines = False
 
@@ -43,19 +44,19 @@ def read_data(self, as_dataarray=False):
         no, ns, nk = map(int, l.split())
 
         # Create the data to contain all band points
-        b = np.empty([nk, ns, no], np.float64)
+        b = _a.emptyd([nk, ns, no])
 
         # for band-lines
         if band_lines:
-            k = np.empty([nk], np.float64)
+            k = _a.emptyd([nk])
             for ik in range(nk):
                 l = [float(x) for x in self.readline().split()]
                 k[ik] = l[0]
                 del l[0]
                 # Now populate the eigenvalues
                 while len(l) < ns * no:
                     l.extend([float(x) for x in self.readline().split()])
-                l = np.array(l, np.float64)
+                l = _a.arrayd(l)
                 l.shape = (ns, no)
                 b[ik, :, :] = l[:, :] - Ef
             # Now we need to read the labels for the points
@@ -69,7 +70,7 @@ def read_data(self, as_dataarray=False):
             vals = (xlabels, labels), k, b
 
         else:
-            k = np.empty([nk, 3], np.float64)
+            k = _a.emptyd([nk, 3])
             for ik in range(nk):
                 l = [float(x) for x in self.readline().split()]
                 k[ik, :] = l[0:3]
@@ -79,26 +80,20 @@ def read_data(self, as_dataarray=False):
                 # Now populate the eigenvalues
                 while len(l) < ns * no:
                     l.extend([float(x) for x in self.readline().split()])
-                l = np.array(l, np.float64)
+                l = _a.arrayd(l)
                 l.shape = (ns, no)
                 b[ik, :, :] = l[:, :] - Ef
             vals = k, b
 
         if as_dataarray:
             from xarray import DataArray
 
-            ticks = {"tick_vals": xlabels, "tick_labels": labels} if band_lines else {}
+            ticks = {"ticks": xlabels, "ticklabels": labels} if band_lines else {}
 
-            return DataArray(
-                name="Energy",
-                data=b,
-                coords=[
-                    ("K", k),
-                    ("spin", np.arange(0,b.shape[1])),
-                    ("iBand", np.arange(0,b.shape[2]) + 1)
-                ],
-                attrs= {**ticks}
-            )
+            return DataArray(b, name="Energy", attrs=ticks,
+                             coords=[("k", k),
+                                     ("spin", _a.arangei(0, b.shape[1])),
+                                     ("band", _a.arangei(0, b.shape[2]))])
 
         return vals
 

sisl/io/siesta/pdos.py

@@ -106,7 +106,7 @@ def to(o, DOS):
                 return xr.DataArray(data=process(DOS).reshape(shape),
                                     dims=dims, coords=coords, name='PDOS')
 
-            D = xr.DataArray()
+            D = xr.DataArray([])
         else:
             def to(o, DOS):
                 return process(DOS)

sisl/io/siesta/tests/test_bands.py

@@ -15,13 +15,6 @@ def test_fe(sisl_files):
     assert k.shape == (131, )
     assert eig.shape == (131, 2, 15)
     assert len(labels[0]) == 5
-    #Test the dataarray implementation
-    bands = si.read_data(as_dataarray=True)
-    assert bands['K'].shape == (131,)
-    assert bands['spin'].shape == (2,)
-    assert bands['iBand'].shape == (15,)
-    assert len(bands.tick_vals) == len(bands.tick_labels) == 5
-
 
 def test_fe_ArgumentParser(sisl_files, sisl_tmp):
     try:
@@ -34,3 +27,17 @@ def test_fe_ArgumentParser(sisl_files, sisl_tmp):
     p.parse_args([], namespace=ns)
     p.parse_args(['--energy', ' -2:2'], namespace=ns)
     p.parse_args(['--energy', ' -2:2', '--plot', png], namespace=ns)
+
+
+def test_fe_xarray(sisl_files, sisl_tmp):
+    try:
+        import xarray
+    except ImportError:
+        pytest.skip('xarray not available')
+    si = sisl.get_sile(sisl_files(_dir, 'fe.bands'))
+
+    bands = si.read_data(as_dataarray=True)
+    assert len(bands['k']) == 131
+    assert len(bands['spin']) == 2
+    assert len(bands['band']) == 15
+    assert len(bands.ticks) == len(bands.ticklabels) == 5