Évite une 500 si le formulaire de profil ne contient pas tous les champs

- Ajoute les tests corresondants
- Refactorise le code

Author: philippemilink

zds/member/tests/tests_forms.py

@@ -238,6 +238,11 @@ def test_too_long_signature_miniprofile_form(self):
         form = MiniProfileForm(data=data)
         self.assertFalse(form.is_valid())
 
+    def test_missing_non_required_fields_miniprofile_form(self):
+        data = {}
+        form = MiniProfileForm(data=data)
+        self.assertTrue(form.is_valid())
+
 
 class ProfileFormTest(TestCase):
     """

zds/member/tests/tests_views.py

@@ -0,0 +1,75 @@
+from django.test import TestCase
+from django.urls import reverse
+
+from zds.member.tests.factories import ProfileFactory
+
+
+class UpdateMemberViewTest(TestCase):
+    def setUp(self):
+        self.profile = ProfileFactory()
+
+    def test_full_form(self):
+        self.client.force_login(self.profile.user)
+
+        new_biography = "Biography"
+        new_site = "https://perdu.com"
+        new_avatar_url = "https://site.foo/img.png"
+        new_sign = "My signature"
+
+        response = self.client.post(
+            reverse("update-member"),
+            {"biography": new_biography, "site": new_site, "avatar_url": new_avatar_url, "sign": new_sign},
+        )
+        self.assertEqual(302, response.status_code)
+
+        self.profile.refresh_from_db()
+
+        self.assertEqual(self.profile.biography, new_biography)
+        self.assertEqual(self.profile.site, new_site)
+        self.assertEqual(self.profile.avatar_url, new_avatar_url)
+        self.assertEqual(self.profile.sign, new_sign)
+
+    def test_blank_form(self):
+        self.client.force_login(self.profile.user)
+
+        self.profile.biography = "Biography"
+        self.profile.site = "https://perdu.com"
+        self.profile.avatar_url = "https://site.foo/img.png"
+        self.profile.sign = "My signature"
+        self.profile.save()
+
+        response = self.client.post(
+            reverse("update-member"), {"biography": "", "site": "", "avatar_url": "", "sign": ""}
+        )
+        self.assertEqual(302, response.status_code)
+
+        self.profile.refresh_from_db()
+
+        self.assertEqual(self.profile.biography, "")
+        self.assertEqual(self.profile.site, "")
+        self.assertEqual(self.profile.avatar_url, "")
+        self.assertEqual(self.profile.sign, "")
+
+    def test_empty_form(self):
+        self.client.force_login(self.profile.user)
+
+        initial_biography = "Biography"
+        initial_site = "https://perdu.com"
+        initial_avatar_url = "https://site.foo/img.png"
+        initial_sign = "My signature"
+
+        self.profile.biography = initial_biography
+        self.profile.site = initial_site
+        self.profile.avatar_url = initial_avatar_url
+        self.profile.sign = initial_sign
+        self.profile.save()
+
+        response = self.client.post(reverse("update-member"), {})
+        self.assertEqual(302, response.status_code)
+
+        self.profile.refresh_from_db()
+
+        self.assertEqual(self.profile.biography, initial_biography)
+        self.assertEqual(self.profile.site, initial_site)
+        self.assertEqual(self.profile.avatar_url, initial_avatar_url)
+        self.assertEqual(self.profile.sign, initial_sign)

zds/member/views/profile.py

@@ -267,19 +267,13 @@ def form_valid(self, form):
         return response
 
     def update_profile(self, profile, form):
+        for field in ["biography", "site", "avatar_url", "sign", "licence"]:
+            if field in form.data:
+                profile.__setattr__(field, form.cleaned_data.get(field, ""))
+
         cleaned_data_options = form.cleaned_data.get("options")
-        profile.biography = form.data["biography"]
-        profile.site = form.data["site"]
-        profile.show_sign = "show_sign" in cleaned_data_options
-        profile.is_hover_enabled = "is_hover_enabled" in cleaned_data_options
-        profile.allow_temp_visual_changes = "allow_temp_visual_changes" in cleaned_data_options
-        profile.show_markdown_help = "show_markdown_help" in cleaned_data_options
-        profile.email_for_answer = "email_for_answer" in cleaned_data_options
-        profile.email_for_new_mp = "email_for_new_mp" in cleaned_data_options
-        profile.hide_forum_activity = "hide_forum_activity" in cleaned_data_options
-        profile.avatar_url = form.data["avatar_url"]
-        profile.sign = form.data["sign"]
-        profile.licence = form.cleaned_data["licence"]
+        for option in [m[0] for m in self.form_class.multi_choices]:
+            profile.__setattr__(option, option in cleaned_data_options)
 
     def get_success_url(self):
         return reverse("update-member")