remove max payload check (#137)

skosito · web-flow · commit b5f5e9f1d7f5 · 2025-11-28T16:43:34.000+01:00
diff --git a/programs/gateway/src/errors.rs b/programs/gateway/src/errors.rs
@@ -13,8 +13,6 @@ pub enum Errors {
     DepositToAddressMismatch,
     #[msg("MessageHashMismatch")]
     MessageHashMismatch,
-    #[msg("MemoLengthExceeded")]
-    MemoLengthExceeded,
     #[msg("DepositPaused")]
     DepositPaused,
     #[msg("SPLAtaAndMintAddressMismatch")]
diff --git a/programs/gateway/src/instructions/deposit.rs b/programs/gateway/src/instructions/deposit.rs
@@ -2,7 +2,6 @@ use crate::{
     contexts::{Call, Deposit, DepositSplToken},
     errors::Errors,
     state::RevertOptions,
-    utils::verify_payload_size,
 };
 
 use anchor_lang::prelude::*;
@@ -18,8 +17,6 @@ pub fn handle_sol(
     revert_options: Option<RevertOptions>,
     deposit_fee: u64,
 ) -> Result<()> {
-    verify_payload_size(None, &revert_options)?;
-
     let pda = &mut ctx.accounts.pda;
     require!(!pda.deposit_paused, Errors::DepositPaused);
     require!(receiver != [0u8; 20], Errors::EmptyReceiver);
@@ -55,8 +52,6 @@ pub fn handle_sol_with_call(
     revert_options: Option<RevertOptions>,
     deposit_fee: u64,
 ) -> Result<()> {
-    verify_payload_size(Some(&message), &revert_options)?;
-
     handle_sol(ctx, amount, receiver, revert_options, deposit_fee)?;
 
     msg!("Deposit and call executed with message = {:?}", message);
@@ -72,7 +67,6 @@ pub fn handle_spl(
     revert_options: Option<RevertOptions>,
     deposit_fee: u64,
 ) -> Result<()> {
-    verify_payload_size(None, &revert_options)?;
     let token = &ctx.accounts.token_program;
     let from = &ctx.accounts.from;
 
@@ -127,8 +121,6 @@ pub fn handle_spl_with_call(
     revert_options: Option<RevertOptions>,
     deposit_fee: u64,
 ) -> Result<()> {
-    verify_payload_size(Some(&message), &revert_options)?;
-
     handle_spl(ctx, amount, receiver, revert_options, deposit_fee)?;
 
     msg!("Deposit SPL and call executed with message = {:?}", message);
@@ -144,7 +136,6 @@ pub fn handle_call(
     revert_options: Option<RevertOptions>,
 ) -> Result<()> {
     require!(receiver != [0u8; 20], Errors::EmptyReceiver);
-    verify_payload_size(Some(&message), &revert_options)?;
 
     msg!(
         "Call executed: receiver = {:?}, message = {:?}, revert options = {:?}",
diff --git a/programs/gateway/src/utils/constants.rs b/programs/gateway/src/utils/constants.rs
@@ -4,8 +4,5 @@ pub const ZETACHAIN_PREFIX: &[u8] = b"ZETACHAIN";
 /// Default gas cost in lamports for SPL token operations
 pub const DEFAULT_GAS_COST: u64 = 5000;
 
-// Maximum size of a message payload in bytes
-pub const MAX_DEPOSIT_PAYLOAD_SIZE: usize = 745;
-
 /// Deposit fee used when depositing SOL or SPL tokens.
 pub const DEPOSIT_FEE: u64 = 2_000_000;
diff --git a/programs/gateway/src/utils/mod.rs b/programs/gateway/src/utils/mod.rs
@@ -6,7 +6,6 @@ pub mod validate_message_hash;
 pub mod verify_and_update_nonce;
 pub mod verify_ata_match;
 pub mod verify_authority;
-pub mod verify_payload_size;
 
 pub use constants::*;
 pub use prepare_account_metas::*;
@@ -16,4 +15,3 @@ pub use validate_message_hash::*;
 pub use verify_and_update_nonce::*;
 pub use verify_ata_match::*;
 pub use verify_authority::*;
-pub use verify_payload_size::*;
diff --git a/programs/gateway/src/utils/verify_payload_size.rs b/programs/gateway/src/utils/verify_payload_size.rs
diff --git a/tests/gateway.ts b/tests/gateway.ts
@@ -44,7 +44,6 @@ const revertOptions = {
 const usdcDecimals = 6;
 const chain_id = 111111;
 const chain_id_bn = new anchor.BN(chain_id);
-const maxPayloadSize = 745;
 
 async function mintSPLToken(
   conn: anchor.web3.Connection,
@@ -286,82 +285,6 @@ describe("Gateway", () => {
     }
   });
 
-  it("Deposit 1_000_000 USDC with above max payload size should fail", async () => {
-    const pda_ata = await getOrCreateAssociatedTokenAccount(
-      conn,
-      wallet,
-      mint.publicKey,
-      pdaAccount,
-      true
-    );
-    const tokenAccount = await getOrCreateAssociatedTokenAccount(
-      conn,
-      wallet,
-      mint.publicKey,
-      wallet.publicKey
-    );
-    try {
-      await gatewayProgram.methods
-        .depositSplTokenAndCall(
-          new anchor.BN(2_000_000),
-          Array.from(address),
-          Buffer.from(Array(maxPayloadSize + 1).fill(1)),
-          null
-        )
-        .accounts({
-          from: tokenAccount.address,
-          to: pda_ata.address,
-          mintAccount: mint.publicKey,
-        })
-        .preInstructions([
-          ComputeBudgetProgram.setComputeUnitLimit({ units: 400000 }),
-        ])
-        .rpc({ commitment: "processed" });
-      throw new Error("Expected error not thrown");
-    } catch (err) {
-      expect(err).to.be.instanceof(anchor.AnchorError);
-      expect(err.message).to.include("MemoLengthExceeded");
-    }
-  });
-
-  it("Deposit 1_000_000 USDC with with max payload size", async () => {
-    const pda_ata = await getOrCreateAssociatedTokenAccount(
-      conn,
-      wallet,
-      mint.publicKey,
-      pdaAccount,
-      true
-    );
-    const tokenAccount = await getOrCreateAssociatedTokenAccount(
-      conn,
-      wallet,
-      mint.publicKey,
-      wallet.publicKey
-    );
-    let acct = await spl.getAccount(conn, pda_ata.address);
-    const bal1 = acct.amount;
-
-    await gatewayProgram.methods
-      .depositSplTokenAndCall(
-        new anchor.BN(2_000_000),
-        Array.from(address),
-        Buffer.from(Array(maxPayloadSize).fill(1)),
-        null
-      )
-      .accounts({
-        from: tokenAccount.address,
-        to: pda_ata.address,
-        mintAccount: mint.publicKey,
-      })
-      .preInstructions([
-        ComputeBudgetProgram.setComputeUnitLimit({ units: 400000 }),
-      ])
-      .rpc({ commitment: "processed" });
-    acct = await spl.getAccount(conn, pda_ata.address);
-    const bal2 = acct.amount;
-    expect(bal2 - bal1).to.be.eq(2_000_000n);
-  });
-
   it("Deposit 1_000_000 USDC to Gateway", async () => {
     let pda_ata = await getOrCreateAssociatedTokenAccount(
       conn,
@@ -541,7 +464,7 @@ describe("Gateway", () => {
       expect(err).to.be.instanceof(anchor.AnchorError);
       expect(err.message).to.include("NonceMismatch");
       const account4 = await spl.getAccount(conn, pda_ata);
-      expect(account4.amount).to.be.eq(4_500_000n);
+      expect(account4.amount).to.be.eq(2_500_000n);
     }
 
     try {
@@ -583,7 +506,7 @@ describe("Gateway", () => {
       expect(err).to.be.instanceof(anchor.AnchorError);
       expect(err.message).to.include("ConstraintAssociated");
       const account4 = await spl.getAccount(conn, pda_ata);
-      expect(account4.amount).to.be.eq(4_500_000n);
+      expect(account4.amount).to.be.eq(2_500_000n);
     }
   });
 
@@ -3694,23 +3617,6 @@ describe("Gateway", () => {
     }
   });
 
-  it("Deposit and call with above max payload size should fail", async () => {
-    try {
-      await gatewayProgram.methods
-        .depositAndCall(
-          new anchor.BN(1_000_000_000),
-          Array.from(address),
-          Buffer.from(Array(maxPayloadSize + 1).fill(1)),
-          revertOptions
-        )
-        .rpc();
-      throw new Error("Expected error not thrown");
-    } catch (err) {
-      expect(err).to.be.instanceof(anchor.AnchorError);
-      expect(err.message).to.include("MemoLengthExceeded");
-    }
-  });
-
   it("Call with empty address receiver should fail", async () => {
     try {
       await gatewayProgram.methods
@@ -3723,54 +3629,6 @@ describe("Gateway", () => {
     }
   });
 
-  it("Call with above max payload size should fail", async () => {
-    try {
-      await gatewayProgram.methods
-        .call(
-          Array.from(address),
-          Buffer.from(Array(maxPayloadSize + 1).fill(1)),
-          revertOptions
-        )
-        .rpc();
-      throw new Error("Expected error not thrown");
-    } catch (err) {
-      expect(err).to.be.instanceof(anchor.AnchorError);
-      expect(err.message).to.include("MemoLengthExceeded");
-    }
-  });
-
-  it("Call with max payload size", async () => {
-    const txsig = await gatewayProgram.methods
-      .call(
-        Array.from(address),
-        Buffer.from(Array(maxPayloadSize).fill(1)),
-        revertOptions
-      )
-      .preInstructions([
-        ComputeBudgetProgram.setComputeUnitLimit({ units: 400000 }),
-      ])
-      .rpc({ commitment: "processed" });
-    await conn.getParsedTransaction(txsig, "confirmed");
-  });
-
-  it("Deposit and call with max payload size", async () => {
-    const bal1 = await conn.getBalance(pdaAccount);
-    const txsig = await gatewayProgram.methods
-      .depositAndCall(
-        new anchor.BN(1_000_000_000),
-        Array.from(address),
-        Buffer.from(Array(maxPayloadSize).fill(1)),
-        revertOptions
-      )
-      .preInstructions([
-        ComputeBudgetProgram.setComputeUnitLimit({ units: 400000 }),
-      ])
-      .rpc({ commitment: "processed" });
-    await conn.getParsedTransaction(txsig, "confirmed");
-    const bal2 = await conn.getBalance(pdaAccount);
-    expect(bal2 - bal1).to.be.gte(1_000_000_000);
-  });
-
   it("Deposit and call", async () => {
     let bal1 = await conn.getBalance(pdaAccount);
     const txsig = await gatewayProgram.methods
