Skip to content

Commit db8e7be

Browse files
authored
sort InferenceModelRewrite lists by (Namespace, Name) in tests (kubernetes-sigs#1917)
Signed-off-by: CYJiang <[email protected]>
1 parent ea4a56f commit db8e7be

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

pkg/epp/controller/inferencemodelrewrite_reconciler_test.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
"time"
2323

2424
"github.com/google/go-cmp/cmp"
25+
"github.com/google/go-cmp/cmp/cmpopts"
2526
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2627
"k8s.io/apimachinery/pkg/runtime"
2728
"k8s.io/apimachinery/pkg/runtime/schema"
@@ -225,9 +226,16 @@ func diffStoreRewrites(ds datastore.Datastore, wantRewrites []*v1alpha2.Inferenc
225226
if wantRewrites == nil {
226227
wantRewrites = []*v1alpha2.InferenceModelRewrite{}
227228
}
228-
229229
gotRewrites := ds.ModelRewriteGetAll()
230-
if diff := cmp.Diff(wantRewrites, gotRewrites); diff != "" {
230+
231+
less := func(a, b *v1alpha2.InferenceModelRewrite) bool {
232+
if a.Namespace != b.Namespace {
233+
return a.Namespace < b.Namespace
234+
}
235+
return a.Name < b.Name
236+
}
237+
238+
if diff := cmp.Diff(wantRewrites, gotRewrites, cmpopts.SortSlices(less)); diff != "" {
231239
return "rewrites:" + diff
232240
}
233241
return ""

0 commit comments

Comments
 (0)