Reduce log spam from naggy mocks in tests (facebook#54047)

Summary:
Pull Request resolved: facebook#54047

TSIA

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D83825727

fbshipit-source-id: a4a8ffc38571596985ae2687142dbc8a974be39c

Author: motiz88

packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorMocks.h

@@ -97,6 +97,7 @@ class MockInspectorPackagerConnectionDelegate
             executor_.add(callback);
           }
         }));
+    EXPECT_CALL(*this, scheduleCallback(_, _)).Times(AnyNumber());
   }
 
   // InspectorPackagerConnectionDelegate methods
@@ -168,6 +169,15 @@ class MockRuntimeTargetDelegate : public RuntimeTargetDelegate {
       collectSamplingProfile,
       (),
       (override));
+
+  inline MockRuntimeTargetDelegate() {
+    using namespace testing;
+
+    // Silence "uninteresting mock function call" warnings for methods that
+    // don't have side effects.
+
+    EXPECT_CALL(*this, supportsConsole()).Times(AnyNumber());
+  }
 };
 
 class MockRuntimeAgentDelegate : public RuntimeAgentDelegate {

packages/react-native/ReactCommon/jsinspector-modern/tests/InspectorPackagerConnectionTest.cpp

@@ -49,6 +49,8 @@ class InspectorPackagerConnectionTestBase : public testing::Test {
           socket->getDelegate().didOpen();
           return std::move(socket);
         });
+    EXPECT_CALL(*packagerConnectionDelegate(), connectWebSocket(_, _))
+        .Times(AnyNumber());
   }
 
   void TearDown() override {

packages/react-native/ReactCommon/jsinspector-modern/tests/ReactInstanceIntegrationTest.h

@@ -50,7 +50,7 @@ class ReactInstanceIntegrationTest
   std::shared_ptr<MockMessageQueueThread> messageQueueThread;
   std::shared_ptr<ErrorUtils> errorHandler;
 
-  MockRemoteConnection& getRemoteConnection() {
+  NiceMock<MockRemoteConnection>& getRemoteConnection() {
     EXPECT_EQ(mockRemoteConnections_.objectsVended(), 1);
     auto rawPtr = mockRemoteConnections_[0];
     assert(rawPtr);
@@ -64,7 +64,7 @@ class ReactInstanceIntegrationTest
   size_t id_ = 1;
   bool verbose_ = false;
   std::optional<int> pageId_;
-  UniquePtrFactory<MockRemoteConnection> mockRemoteConnections_;
+  UniquePtrFactory<NiceMock<MockRemoteConnection>> mockRemoteConnections_;
   std::unique_ptr<ILocalConnection> clientToVM_;
   folly::QueuedImmediateExecutor immediateExecutor_;
   MockHostTargetDelegate hostTargetDelegate_;