Skip to content

Commit 8c45add

Browse files
committed
Fix broken cron scripts
I found that none of the daily, hourly, weekly or monthly snapshots were being taken. When I looked into it I found that the scripts didn't execute properly, because of the newly introduced check (9c6f065). I'm not versed enough with POSIX to understand if there was some clever intention with using exec than just calling which by it self, but it works without exec so I removed it.
1 parent 9c6f065 commit 8c45add

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

etc/zfs-auto-snapshot.cron.daily

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/sh
22

33
# Only call zfs-auto-snapshot if it's available
4-
exec which zfs-auto-snapshot > /dev/null && \
4+
which zfs-auto-snapshot > /dev/null && \
55
zfs-auto-snapshot --quiet --syslog --label=daily --keep=31 //

etc/zfs-auto-snapshot.cron.hourly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/sh
22

33
# Only call zfs-auto-snapshot if it's available
4-
exec which zfs-auto-snapshot > /dev/null && \
4+
which zfs-auto-snapshot > /dev/null && \
55
zfs-auto-snapshot --quiet --syslog --label=hourly --keep=24 //

etc/zfs-auto-snapshot.cron.monthly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/sh
22

33
# Only call zfs-auto-snapshot if it's available
4-
exec which zfs-auto-snapshot > /dev/null && \
4+
which zfs-auto-snapshot > /dev/null && \
55
zfs-auto-snapshot --quiet --syslog --label=monthly --keep=12 //

etc/zfs-auto-snapshot.cron.weekly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/sh
22

33
# Only call zfs-auto-snapshot if it's available
4-
exec which zfs-auto-snapshot > /dev/null && \
4+
which zfs-auto-snapshot > /dev/null && \
55
zfs-auto-snapshot --quiet --syslog --label=weekly --keep=8 //

0 commit comments

Comments
 (0)