refactor: replace supportsMaxTokens with maxTokensKey for flexible token parameter naming (#563)

* refactor: replace supportsMaxTokens with maxTokensKey for flexible token parameter naming

* refactor(zgsm): improve type safety and token handling logic

Author: mini2s

packages/types/src/model.ts

@@ -57,7 +57,8 @@ export const modelInfoSchema = z.object({
 	maxThinkingTokens: z.number().nullish(),
 	contextWindow: z.number(),
 	supportsImages: z.boolean().optional(),
-	supportsMaxTokens: z.boolean().optional(),
+	// `max_completion_tokens`，`max_tokens` ,undefined
+	maxTokensKey: z.string().optional(),
 	supportsComputerUse: z.boolean().optional(),
 	supportsPromptCache: z.boolean(),
 	// Capability flag to indicate whether the model supports an output verbosity parameter

packages/types/src/providers/zgsm.ts

@@ -6,7 +6,7 @@ export const zgsmModels = {
 	default: {
 		maxTokens: 8192,
 		contextWindow: 128_000,
-		supportsMaxTokens: false,
+		maxTokensKey: undefined,
 		supportsImages: false,
 		supportsComputerUse: false,
 		supportsPromptCache: true,

src/api/providers/zgsm.ts

@@ -262,7 +262,7 @@ export class ZgsmAiHandler extends BaseProvider implements SingleCompletionHandl
 		requestId: string,
 		clientId: string,
 		workspacePath: string,
-		chatType?: string,
+		chatType?: "user" | "system",
 	): Record<string, string> {
 		return {
 			"Accept-Language": metadata?.language || "en",
@@ -685,14 +685,19 @@ export class ZgsmAiHandler extends BaseProvider implements SingleCompletionHandl
 		modelInfo: ModelInfo,
 	): void {
 		// Only add max_completion_tokens if includeMaxTokens is true
-		if (
-			(this.options.includeMaxTokens === true && this.options.useZgsmCustomConfig) ||
-			!this.options.useZgsmCustomConfig
-		) {
+		if (this.options.useZgsmCustomConfig) {
+			const maxTokens = this.options.modelMaxTokens || modelInfo.maxTokens
 			// Use user-configured modelMaxTokens if available, otherwise fall back to model's default maxTokens
 			// Using max_completion_tokens as max_tokens is deprecated
-			requestOptions[modelInfo.supportsMaxTokens ? "max_tokens" : "max_completion_tokens"] =
-				this.options.modelMaxTokens || modelInfo.maxTokens
+			if (this.options.includeMaxTokens) {
+				Object.assign(requestOptions, {
+					[modelInfo.maxTokensKey || "max_completion_tokens"]: maxTokens,
+				})
+			}
+		} else if (modelInfo.maxTokensKey) {
+			Object.assign(requestOptions, {
+				[modelInfo.maxTokensKey]: modelInfo.maxTokens,
+			})
 		}
 	}
 

webview-ui/src/components/chat/ModeSelector.tsx

@@ -192,7 +192,7 @@ export const ModeSelector = ({
 
 	return (
 		<Popover open={open} onOpenChange={onOpenChange} data-testid="mode-selector-root">
-			<StandardTooltip content={title}>
+			<StandardTooltip content={`${title} (${zgsmCodeMode})`}>
 				<PopoverTrigger
 					disabled={disabled}
 					data-testid="mode-selector-trigger"
@@ -209,7 +209,9 @@ export const ModeSelector = ({
 							? "bg-primary opacity-90 hover:bg-primary-hover text-vscode-button-foreground"
 							: null,
 					)}>
-					<span className="truncate">{selectedMode?.name || ""}</span>
+					<span className="truncate">
+						{selectedMode?.name || ""} ({zgsmCodeMode})
+					</span>
 				</PopoverTrigger>
 			</StandardTooltip>
 			<PopoverContent