Skip to content

Commit 9dcca27

Browse files
authored
fix: an infinite loop in login (#134)
1 parent 9034268 commit 9dcca27

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

src/core/webview/webviewMessageHandler.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,11 +1106,7 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
11061106
if (message.text && message.apiConfiguration) {
11071107
await provider.upsertApiConfiguration(message.text, {
11081108
...message.apiConfiguration,
1109-
zgsmBaseUrl:
1110-
`${message.apiConfiguration.zgsmBaseUrl || message.apiConfiguration.zgsmDefaultBaseUrl}`.replace(
1111-
/\/+$/,
1112-
"",
1113-
),
1109+
zgsmBaseUrl: `${message.apiConfiguration.zgsmBaseUrl}`.replace(/\/+$/, ""),
11141110
})
11151111
}
11161112
break

src/zgsmAuth/zgsmAuthHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export async function afterZgsmPostLogin({
7575
}) {
7676
try {
7777
const [zgsmModels, zgsmDefaultModelId, err] = await getZgsmModels(
78-
apiConfiguration.zgsmBaseUrl || defaultZgsmAuthConfig.baseUrl,
78+
apiConfiguration?.zgsmBaseUrl || apiConfiguration?.zgsmDefaultBaseUrl || defaultZgsmAuthConfig.baseUrl,
7979
accessToken,
8080
apiConfiguration.openAiHostHeader,
8181
)

zgsm/src/codeCompletion/completionClient.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ export class CompletionClient {
4343
private async getApiConfig(hasView: boolean, apiConfiguration: any) {
4444
if (hasView) {
4545
return {
46-
baseUrl: apiConfiguration.zgsmBaseUrl || defaultZgsmAuthConfig.baseUrl,
46+
baseUrl:
47+
apiConfiguration.zgsmBaseUrl ||
48+
apiConfiguration.zgsmDefaultBaseUrl ||
49+
defaultZgsmAuthConfig.baseUrl,
4750
completionUrl: apiConfiguration.zgsmCompletionUrl || defaultZgsmAuthConfig.completionUrl,
4851
apiKey: apiConfiguration.zgsmApiKey || NOT_PROVIDERED,
4952
}

zgsm/src/common/services.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,9 @@ export async function handleStatusBarClick() {
440440
if (needLogin) {
441441
statusBarloginCallback({
442442
...apiConfiguration,
443-
zgsmBaseUrl: hasView ? apiConfiguration.zgsmBaseUrl : (globalStateZgsmBaseUrl as string),
443+
zgsmBaseUrl: hasView
444+
? apiConfiguration.zgsmBaseUrl || apiConfiguration.zgsmDefaultBaseUrl
445+
: (globalStateZgsmBaseUrl as string),
444446
})
445447

446448
return

0 commit comments

Comments
 (0)