Skip to content

Commit 05a4b58

Browse files
bkonyiyuuangzhang
authored andcommitted
Re-enable bash_entrypoint_test.dart (flutter#165809)
The test was fixed in flutter@d443df0 but never re-enabled. Fixes flutter#160689
1 parent a199bb4 commit 05a4b58

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/flutter_tools/test/integration.shard/bash_entrypoint_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,15 +94,15 @@ echo downloaded dart sdk
9494
''');
9595
makeExecutable(updateDartSdk);
9696

97-
final File udpateEngine = tempDir
97+
final File updateEngine = tempDir
9898
.childDirectory('bin')
9999
.childDirectory('internal')
100100
.childFile('update_engine_version.sh')..writeAsStringSync('''
101101
#!/usr/bin/env bash
102102
103103
echo engine version
104104
''');
105-
makeExecutable(udpateEngine);
105+
makeExecutable(updateEngine);
106106

107107
// create a fake dart runtime
108108
final File dartBin = (tempDir
@@ -130,7 +130,7 @@ echo executed dart binary
130130
} finally {
131131
tryToDelete(tempDir);
132132
}
133-
}, skip: true); // [intended] https://github.com/flutter/flutter/issues/160689
133+
}, skip: platform.isWindows); // [intended] Windows does not use the bash entrypoint);
134134
}
135135

136136
// A test Dart app that will run until it receives SIGTERM

0 commit comments

Comments
 (0)